<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114927/">https://git.reviewboard.kde.org/r/114927/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 25th, 2014, 7:56 a.m. PST, <b>Scarlett Clark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is becoming a big issue the farther into teir 3 packaging I get. In my humble opinion renaming the xml files (appending a 5) would make everything happy.</pre>
</blockquote>
<p>On January 25th, 2014, 9:04 a.m. PST, <b>Michael Palimaka</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In other frameworks, the change has been made so far by installing it with a kf5_ prefix. For solid however, this only fixes half the problem. A few org.freedesktop files collide, and apparently they cannot be renamed.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, I am seeing that now, renaming breaks solid altogether. Further invesigating required...</pre>
<br />
<p>- Scarlett</p>
<br />
<p>On January 22nd, 2014, 3:23 a.m. PST, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 3:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libsolid installs dbus interface files which have the same filename as those from kdelibs4. Many packagers are unable to work with this.
This proposal renames with a KF5 namespace the files installed.
It also does not install the freedesktop dbus files, source using these will need to bundle the files themselves.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/org.kde.KF5Solid.PowerManagement.PolicyAgent.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/CMakeLists.txt <span style="color: grey">(0bc2abb)</span></li>
<li>src/solid/org.kde.KF5Solid.Networking.Client.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/org.kde.Solid.Networking.Client.xml <span style="color: grey">(70b46de)</span></li>
<li>src/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml <span style="color: grey">(a07dd73)</span></li>
<li>src/solid/powermanagement.cpp <span style="color: grey">(25d1ae6)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(5933708)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>