<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114927/">https://git.reviewboard.kde.org/r/114927/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114927/diff/1/?file=233610#file233610line35" style="color: black; font-weight: bold; text-decoration: underline;">src/solid/powermanagement.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">policyAgentIface</span><span class="p">(</span><span class="s">"org.kde.Solid.PowerManagement.PolicyAgent"</span><span class="p">,</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">35</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">policyAgentIface</span><span class="p">(</span><span class="s">"org.kde.<span class="hl">KF5</span>Solid.PowerManagement.PolicyAgent"</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this change needed? Only XML names changed, interfaces are the same (at least in this diff)
Same for other changes in this file.
I'd keep interfaces as they are, and only rename xml's, but that's more for Solid guys to say ;-)</pre>
</div>
<br />
<p>- Hrvoje Senjan</p>
<br />
<p>On January 22nd, 2014, 11:23 a.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 11:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libsolid installs dbus interface files which have the same filename as those from kdelibs4. Many packagers are unable to work with this.
This proposal renames with a KF5 namespace the files installed.
It also does not install the freedesktop dbus files, source using these will need to bundle the files themselves.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/org.kde.KF5Solid.PowerManagement.PolicyAgent.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/CMakeLists.txt <span style="color: grey">(0bc2abb)</span></li>
<li>src/solid/org.kde.KF5Solid.Networking.Client.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/org.kde.Solid.Networking.Client.xml <span style="color: grey">(70b46de)</span></li>
<li>src/solid/org.kde.Solid.PowerManagement.PolicyAgent.xml <span style="color: grey">(a07dd73)</span></li>
<li>src/solid/powermanagement.cpp <span style="color: grey">(25d1ae6)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(5933708)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114927/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>