<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115229/">https://git.reviewboard.kde.org/r/115229/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I will basically hardcode 1 in xrandr11 backend, the rest is all good to go.
Is this closing any bug/crash? if so, should I make a release?</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115229/diff/3/?file=235263#file235263line86" style="color: black; font-weight: bold; text-decoration: underline;">backends/xrandr1.1/xrandr11.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool XRandR11::isValid() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ScreenInfo</span> <span class="nf">info</span><span class="p">(</span><span class="n">xcbScreen</span><span class="o">-></span><span class="n">root</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">86</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ScreenInfo</span> <span class="nf">info</span><span class="p">(</span><span class="n">xcbScreen</span><span class="o">-></span><span class="n">root</span><span class="p">);<span class="hl">;</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">remove the extra ;</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115229/diff/3/?file=235263#file235263line93" style="color: black; font-weight: bold; text-decoration: underline;">backends/xrandr1.1/xrandr11.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool XRandR11::isValid() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">93</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">xcb_randr_get_screen_resources_cookie_t</span> <span class="n">cookie</span> <span class="o">=</span> <span class="n">xcb_randr_get_screen_resources</span><span class="p">(</span><span class="n">connection</span><span class="p">(),</span> <span class="n">xcbScreen</span><span class="o">-></span><span class="n">root</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">xcb_randr_get_screen_resources_reply_t</span> <span class="o">*</span><span class="n">screenResources</span> <span class="o">=</span> <span class="n">xcb_randr_get_screen_resources_reply</span><span class="p">(</span><span class="n">connection</span><span class="p">(),</span> <span class="n">cookie</span><span class="p">,</span> <span class="mi">0</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">95</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These were added with XRandR 1.2, see http://cgit.freedesktop.org/xorg/proto/randrproto/tree/randrproto.txt
xrandr11 only can handle 1 screen (actually only the X virutal screen), so nothing to do here.</pre>
</div>
<br />
<p>- Àlex Fiestas</p>
<br />
<p>On January 22nd, 2014, 3:35 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 3:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Config::canBeApplied() now rejects Configs that have more enabled outputs than is supported by GPU. We can't rely on drivers handling this situation, some don't (yup, looking at you, nouveau).
The maximum number of enabled outputs is exposed via a Screen property. In case of XRandR backends, this returns number of available CRTCs.
I will also add a check to KScreen KCM that will show an error and won't allow applying such configuration.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/fake/parser.cpp <span style="color: grey">(f1f5d81)</span></li>
<li>backends/xrandr/xrandrscreen.cpp <span style="color: grey">(d43aab1)</span></li>
<li>backends/xrandr1.1/xrandr11.cpp <span style="color: grey">(b201181)</span></li>
<li>src/config.cpp <span style="color: grey">(a473c2b)</span></li>
<li>src/screen.h <span style="color: grey">(c85c7c2)</span></li>
<li>src/screen.cpp <span style="color: grey">(4446d7c)</span></li>
<li>tests/configs/multipleclone.json <span style="color: grey">(12ef4c0)</span></li>
<li>tests/configs/multipleoutput.json <span style="color: grey">(2b4a8d6)</span></li>
<li>tests/configs/singleOutputWithoutPreferred.json <span style="color: grey">(4e39647)</span></li>
<li>tests/configs/singleoutput.json <span style="color: grey">(da5d08f)</span></li>
<li>tests/configs/singleoutputBroken.json <span style="color: grey">(e3d88cb)</span></li>
<li>tests/configs/tooManyOutputs.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/testscreenconfig.cpp <span style="color: grey">(f40ea22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115229/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>