<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115229/">https://git.reviewboard.kde.org/r/115229/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 43ac4742ac2af413fe5f38494b842a59fc6f426a by Dan Vrátil to branch master.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On January 22nd, 2014, 5:16 p.m. UTC, Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 22, 2014, 5:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Config::canBeApplied() now rejects Configs that have more enabled outputs than is supported by GPU. We can't rely on drivers handling this situation, some don't (yup, looking at you, nouveau).
The maximum number of enabled outputs is exposed via a Screen property. In case of XRandR backends, this returns number of available CRTCs.
I will also add a check to KScreen KCM that will show an error and won't allow applying such configuration.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/fake/parser.cpp <span style="color: grey">(f1f5d81)</span></li>
<li>backends/xrandr/xrandrscreen.cpp <span style="color: grey">(d43aab1)</span></li>
<li>backends/xrandr1.1/xrandr11.cpp <span style="color: grey">(b201181)</span></li>
<li>src/config.cpp <span style="color: grey">(a473c2b)</span></li>
<li>src/screen.h <span style="color: grey">(c85c7c2)</span></li>
<li>src/screen.cpp <span style="color: grey">(4446d7c)</span></li>
<li>tests/configs/multipleclone.json <span style="color: grey">(12ef4c0)</span></li>
<li>tests/configs/multipleoutput.json <span style="color: grey">(2b4a8d6)</span></li>
<li>tests/configs/singleOutputWithoutPreferred.json <span style="color: grey">(4e39647)</span></li>
<li>tests/configs/singleoutput.json <span style="color: grey">(da5d08f)</span></li>
<li>tests/configs/singleoutputBroken.json <span style="color: grey">(e3d88cb)</span></li>
<li>tests/configs/tooManyOutputs.json <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/testscreenconfig.cpp <span style="color: grey">(f40ea22)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115229/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>