<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114433/">http://git.reviewboard.kde.org/r/114433/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you could port the relevant part to the other helpers (audio, network) that'd be nice, if not I will do it before next release.
The patch is good, so go ahead !</pre>
<br />
<p>- Àlex Fiestas</p>
<br />
<p>On December 13th, 2013, 11:30 a.m. UTC, Aaron J. Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Aaron J. Seigo.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2013, 11:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When a non-existent device is handed to the input helper via the command line it crashes because it gets back a null device. This adds a check for that.
Bonus fixes:
* qApp->exit() only works when called after the event loop is set up; so delay the init of the helper with a singleshot timer; this allows the process to actually exit instead of just hanging
* compiler warning about an unused variable in main.cpp</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tried it with invalid device addresses as well as valid ones, both from the command line and from the bluedevil systray icon.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/actionplugins/input/helper/inputhelper.h <span style="color: grey">(c7b7030)</span></li>
<li>src/actionplugins/input/helper/inputhelper.cpp <span style="color: grey">(db9a0b7)</span></li>
<li>src/actionplugins/input/helper/main.cpp <span style="color: grey">(7fca8f2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114433/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>