<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109352/">http://git.reviewboard.kde.org/r/109352/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Overall, the patch looks fine. What I don't like is the huge mess of names we have among variables/methods/UI strings between Sleep/Suspend/etc... . To be honest, I'd like to see with this patch a unification of everything, where we decide how do we call what (Hibernate included) and be consistent among all of the code and the UI. I admit for a newcomer to the codebase all of this starts to be really really confusing, and exposing different messages in the UI is really bad.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109352/diff/2/?file=139952#file139952line180" style="color: black; font-weight: bold; text-decoration: underline;">plasma/desktop/applets/kickoff/core/leavemodel.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void LeaveModel::updateModel()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">179</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifndef Q_WS_WIN</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see no #endif here... am I missing something? (same below)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109352/diff/2/?file=139964#file139964line260" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/runners/powerdevil/PowerDevilRunner.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void PowerDevilRunner::match(Plasma::RunnerContext &context)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">260</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">252</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Whitespace</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/109352/diff/2/?file=139970#file139970line80" style="color: black; font-weight: bold; text-decoration: underline;">powerdevil/daemon/powerdevilfdoconnector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FdoConnector::Suspend()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">80</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">FdoConnector</span><span class="o">::</span><span class="n">HybridSuspend</span><span class="p">()</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Watch out: this interface is meant for compatibility with fdo ( not that anyone uses it anymore, though... ) and so it should stay as it is. Although I think at some point we might just as well drop it, as we're the only ones to implement it I think.</pre>
</div>
<br />
<p>- Dario Freddi</p>
<br />
<p>On November 27th, 2013, 6:04 p.m. UTC, Lukáš Tinkl wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid, Àlex Fiestas and Dario Freddi.</div>
<div>By Lukáš Tinkl.</div>
<p style="color: grey;"><i>Updated Nov. 27, 2013, 6:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=302968">302968</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the implementation of hybrid suspend method, complementing https://git.reviewboard.kde.org/r/109351/.
The hybrid suspend approach has the advantages of regular suspend (faster resuming than with hibernation) while being safer at the same time in case the battery runs out. More info: http://en.wikipedia.org/wiki/Sleep_mode#Hybrid_sleep
Affected components: shutdown dialog (ksmserver), kickoff, battery monitor, lock_logout applet, powermanagement data engine, powerdevil & its runner
Hybrid suspend becomes the preferred method to put the system into sleep thus greatly simplifying the user interface; if it's not available (because of system or kernel limitation), the current two options (suspend + hibernate) will be presented to the user.
Technically, powerdevil has supported this approach since the beginning and both HAL and upower/systemd backends already implement it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(247c877)</span></li>
<li>ksmserver/themes/default/main.qml <span style="color: grey">(8924fac)</span></li>
<li>plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: grey">(4e83c37)</span></li>
<li>plasma/desktop/applets/kickoff/core/leavemodel.cpp <span style="color: grey">(47559ce)</span></li>
<li>plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <span style="color: grey">(28fba18)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/code/logic.js <span style="color: grey">(974694a)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/code/platform.js <span style="color: grey">(59af3af)</span></li>
<li>plasma/generic/applets/batterymonitor/contents/ui/PopupDialog.qml <span style="color: grey">(76fb1ce)</span></li>
<li>plasma/generic/applets/batterymonitor/platformcontents/touch/code/platform.js <span style="color: grey">(aa57ab8)</span></li>
<li>plasma/generic/applets/lock_logout/contents/ui/config.ui <span style="color: grey">(07579b4)</span></li>
<li>plasma/generic/applets/lock_logout/contents/ui/data.js <span style="color: grey">(9608a21)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.h <span style="color: grey">(512bf6e)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementengine.cpp <span style="color: grey">(33a6e03)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.h <span style="color: grey">(3b974ab)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span style="color: grey">(1b0b8a0)</span></li>
<li>plasma/generic/runners/powerdevil/PowerDevilRunner.cpp <span style="color: grey">(74eb36d)</span></li>
<li>powerdevil/daemon/org.kde.Solid.PowerManagement.xml <span style="color: grey">(70e2c65)</span></li>
<li>powerdevil/daemon/powerdevilbackendinterface.h <span style="color: grey">(91519a9)</span></li>
<li>powerdevil/daemon/powerdevilcore.h <span style="color: grey">(77c3f2f)</span></li>
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: grey">(2dcdbc6)</span></li>
<li>powerdevil/daemon/powerdevilfdoconnector.h <span style="color: grey">(0739187)</span></li>
<li>powerdevil/daemon/powerdevilfdoconnector.cpp <span style="color: grey">(9fd2360)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109352/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>