<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112603/">http://git.reviewboard.kde.org/r/112603/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Sept. 9, 2013, 6:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The assumption that XRandrOutput::currentMode() can never return a null pointer is wrong.
When currentMode() returns a null pointer it means, that there is no such mode in XRandROutput's cache that would match currentModeId. Obvious solution is to re-read modes from xrandr and hope, that xrandr internally have already added the mode and so after re-reading, currentModeId will be pointing to a valid mode cached in XRandROutput.
In case that even after re-reading modes there is still no mode with ID matching currentModeId, then the inconsistency comes from xrandr itself (or rather it's implementation in the driver) and so we choose the safe route and won't change the output at all and just leave it with it's current configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None, can't reproduce the crash.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323107">323107</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=324625">324625</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/xrandr/xrandrconfig.cpp <span style="color: grey">(ff20c79)</span></li>
<li>backends/xrandr/xrandrmode.h <span style="color: grey">(005db6b)</span></li>
<li>backends/xrandr/xrandrmode.cpp <span style="color: grey">(0f465ab)</span></li>
<li>backends/xrandr/xrandroutput.h <span style="color: grey">(a4eb5bf)</span></li>
<li>backends/xrandr/xrandroutput.cpp <span style="color: grey">(2750385)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112603/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>