<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111918/">http://git.reviewboard.kde.org/r/111918/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good to go, as we talked on IRC, we might change some of this before final release but it looks fine.
Haven't been able to test because the patch is not applying though.</pre>
<br />
<p>- Àlex</p>
<br />
<p>On August 9th, 2013, 9:55 a.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid, Àlex Fiestas and Kevin Ottens.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2013, 9:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the support (to solid and udev backend) for:
- keyboards
- pointer (mice, tablets, touchpads and touch-screens)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On two systems</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/solid/src/solid/CMakeLists.txt <span style="color: grey">(7427aca)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakedevice.cpp <span style="color: grey">(e1a386a)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakekeyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakekeyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakepointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakepointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/hal/haldevice.cpp <span style="color: grey">(d1e48fb)</span></li>
<li>tier1/solid/src/solid/backends/hal/haldeviceinterface.h <span style="color: grey">(1d70187)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevdevice.cpp <span style="color: grey">(8e5f9e9)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevkeyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevkeyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevmanager.cpp <span style="color: grey">(e6270a6)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevpointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevpointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udisks/udisksdeviceinterface.h <span style="color: grey">(004732c)</span></li>
<li>tier1/solid/src/solid/backends/upower/upowerdeviceinterface.h <span style="color: grey">(8c6fe5e)</span></li>
<li>tier1/solid/src/solid/device.cpp <span style="color: grey">(d9f3c6d)</span></li>
<li>tier1/solid/src/solid/deviceinterface.h <span style="color: grey">(c94ebbd)</span></li>
<li>tier1/solid/src/solid/deviceinterface.cpp <span style="color: grey">(2cbd777)</span></li>
<li>tier1/solid/src/solid/ifaces/keyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/ifaces/keyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/ifaces/pointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/ifaces/pointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/keyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/keyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/keyboard_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/pointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/pointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/pointingdevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>