<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111918/">http://git.reviewboard.kde.org/r/111918/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 9th, 2013, 9:58 a.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111918/diff/2-3/?file=177495#file177495line77" style="color: black; font-weight: bold; text-decoration: underline;">tier1/solid/src/solid/keyboard.h</a>
<span style="font-weight: normal;">
(Diff revisions 2 - 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Solid</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">layout</span><span class="p">()</span> <span class="k">const</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does that include also the variant (like qwerty/qwertz)?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is up do udev - what it reports as XKBLAYOUT will be shown there.</pre>
<br />
<p>- Ivan</p>
<br />
<p>On August 9th, 2013, 9:55 a.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid, Àlex Fiestas and Kevin Ottens.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2013, 9:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds the support (to solid and udev backend) for:
- keyboards
- pointer (mice, tablets, touchpads and touch-screens)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On two systems</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tier1/solid/src/solid/CMakeLists.txt <span style="color: grey">(7427aca)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakedevice.cpp <span style="color: grey">(e1a386a)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakekeyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakekeyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakepointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/fakehw/fakepointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/hal/haldevice.cpp <span style="color: grey">(d1e48fb)</span></li>
<li>tier1/solid/src/solid/backends/hal/haldeviceinterface.h <span style="color: grey">(1d70187)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevdevice.cpp <span style="color: grey">(8e5f9e9)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevkeyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevkeyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevmanager.cpp <span style="color: grey">(e6270a6)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevpointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udev/udevpointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/backends/udisks/udisksdeviceinterface.h <span style="color: grey">(004732c)</span></li>
<li>tier1/solid/src/solid/backends/upower/upowerdeviceinterface.h <span style="color: grey">(8c6fe5e)</span></li>
<li>tier1/solid/src/solid/device.cpp <span style="color: grey">(d9f3c6d)</span></li>
<li>tier1/solid/src/solid/deviceinterface.h <span style="color: grey">(c94ebbd)</span></li>
<li>tier1/solid/src/solid/deviceinterface.cpp <span style="color: grey">(2cbd777)</span></li>
<li>tier1/solid/src/solid/ifaces/keyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/ifaces/keyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/ifaces/pointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/ifaces/pointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/keyboard.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/keyboard.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/keyboard_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/pointingdevice.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/pointingdevice.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tier1/solid/src/solid/pointingdevice_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>