<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Dne 29.6.2013 16:56, Daniel Nicoletti
napsal(a):<br>
</div>
<blockquote
cite="mid:CACo8zOe8-gcicr4UcE05NyAXsZzHqq7aoZqcsSXn3DpbO09WYg@mail.gmail.com"
type="cite">
<div dir="ltr">I'm sorry but IMO this is shouldn't be made this
way.
<div style="">* Do you really want to carry an option to import
old secrets?</div>
<div style="">* Till when this option will be there, Debian
users normally jump lots of releases...</div>
<div style="">* What if the user decides to use the old applet?
It won't work because the new secrets are in the new format.</div>
<div style=""><br>
</div>
<div style="">IMHO or the same format is used (I don't see why
not), or don't import the secrets at all.</div>
<div style=""><br>
</div>
<div style="">my 2¢</div>
</div>
<div class="gmail_extra"><br>
</div>
</blockquote>
This patch already uses the old format, but we (even you)
implemented a different format before in our secret agent. I just
submitted this patch for review to inform you about changes. The
only thing I'm doing is importing of secrets stored in files (not in
KWallet) and saving them into KWallet (if it's enabled) or into one
file like you implemented in secret agent.<br>
<blockquote
cite="mid:CACo8zOe8-gcicr4UcE05NyAXsZzHqq7aoZqcsSXn3DpbO09WYg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">2013/6/29 Jan Grulich <span dir="ltr"><<a
moz-do-not-send="true" href="mailto:jgrulich@redhat.com"
target="_blank">jgrulich@redhat.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div
style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table style="border:1px #c9c399 solid" cellpadding="8"
width="100%" bgcolor="#f9f3c9">
<tbody>
<tr>
<td> This is an automatically generated e-mail. To
reply, visit: <a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/111295/"
target="_blank">http://git.reviewboard.kde.org/r/111295/</a>
</td>
</tr>
</tbody>
</table>
<br>
<table
style="background-image:url('');background-repeat:repeat-x;border:1px
black solid" cellpadding="8" cellspacing="0"
width="100%" bgcolor="#fefadf">
<tbody>
<tr>
<td>
<div>Review request for Solid, Lukáš Tinkl and
Lamarque Souza.</div>
<div>By Jan Grulich.</div>
<p style="color:grey"><i>Updated June 29, 2013,
8:11 a.m.</i></p>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Changes</h1>
<table style="border:1px solid #b8b5a0"
cellpadding="10" cellspacing="0" width="100%"
bgcolor="#ffffff">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Updated again, I was too hurried. Anyway, I think I could already push this :)</pre>
</td>
</tr>
</tbody>
</table>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Description
</h1>
<table style="border:1px solid #b8b5a0"
cellpadding="10" cellspacing="0" width="100%"
bgcolor="#ffffff">
<tbody>
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">As I promised, here is a patch that should fix secrets compatibility between both NM applets. But there is one little difference which is that VPN secrets has "secrets" key in KWallet entry (according to VPN setting property) instead of "VpnSecrets". Everything is done automatically at first start and there is no information about how many secrets were imported etc.</pre>
</td>
</tr>
</tbody>
</table>
<h1
style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs
(updated)</h1>
<ul style="margin-left:3em;padding-left:0">
<li>editor/connectioneditor.h <span
style="color:grey">(f8fb13f)</span></li>
<li>editor/connectioneditor.cpp <span
style="color:grey">(ee352d2)</span></li>
<li>kded/secretagent.cpp <span
style="color:grey">(dc6f648)</span></li>
</ul>
<p><a moz-do-not-send="true"
href="http://git.reviewboard.kde.org/r/111295/diff/"
style="margin-left:3em" target="_blank">View
Diff</a></p>
</td>
</tr>
</tbody>
</table>
</div>
</div>
<br>
_______________________________________________<br>
Kde-hardware-devel mailing list<br>
<a moz-do-not-send="true"
href="mailto:Kde-hardware-devel@kde.org">Kde-hardware-devel@kde.org</a><br>
<a moz-do-not-send="true"
href="https://mail.kde.org/mailman/listinfo/kde-hardware-devel"
target="_blank">https://mail.kde.org/mailman/listinfo/kde-hardware-devel</a><br>
<br>
</blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
Daniel Nicoletti<br>
<br>
KDE Developer - <a moz-do-not-send="true"
href="http://dantti.wordpress.com" target="_blank">http://dantti.wordpress.com</a>
</div>
</blockquote>
<br>
Cheers,<br>
Jan<br>
<pre class="moz-signature" cols="72">--
Jan Grulich
Red Hat Czech, s.r.o
<a class="moz-txt-link-abbreviated" href="mailto:jgrulich@redhat.com">jgrulich@redhat.com</a></pre>
</body>
</html>