<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110607/">http://git.reviewboard.kde.org/r/110607/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 2f674db466ead221afc29da0022e2c7ccf59c36e by Kai Uwe Broulik to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On May 24th, 2013, 7:12 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 24, 2013, 7:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds support for the capacity property of batteries that tells how much energy can the battery hold compared to what it is designed to.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles.
Needs more testing. On my machine with recentmost UPower (or probably because I broken something) it does not return energy-full-design (which is needed obviously) which makes it fallback to 100% capacity.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/fakehw/fakebattery.h <span style="color: grey">(3ab180b)</span></li>
<li>solid/solid/backends/fakehw/fakebattery.cpp <span style="color: grey">(d1907f6)</span></li>
<li>solid/solid/backends/hal/halbattery.h <span style="color: grey">(15590ad)</span></li>
<li>solid/solid/backends/hal/halbattery.cpp <span style="color: grey">(d91a524)</span></li>
<li>solid/solid/backends/upower/upowerbattery.h <span style="color: grey">(576e06e)</span></li>
<li>solid/solid/backends/upower/upowerbattery.cpp <span style="color: grey">(da0b877)</span></li>
<li>solid/solid/battery.h <span style="color: grey">(9a0929e)</span></li>
<li>solid/solid/battery.cpp <span style="color: grey">(b3016cc)</span></li>
<li>solid/solid/ifaces/battery.h <span style="color: grey">(971914f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110607/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>