<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110135/">http://git.reviewboard.kde.org/r/110135/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110135/diff/2/?file=140639#file140639line280" style="color: black; font-weight: bold; text-decoration: underline;">kcontrol/randr/module/randrmonitor.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool RandrMonitorModule::isLidPresent()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">280</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QDBusConnection</span><span class="o">::</span><span class="n">sessionBus</span><span class="p">().</span><span class="n">connect</span><span class="p">(</span><span class="s">"org.<span class="hl">kde.</span>Solid<span class="hl">.</span>PowerManagement<span class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"/org/</span>kde<span class="hl">/</span>Solid<span class="hl">/</span>PowerManagement<span class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"org.kde.Solid.PowerManagement</span>"</span><span class="p">,</span> <span class="s">"resumingFromSuspend"</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">resumedFromSuspend</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">280</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QDBusConnection</span><span class="o">::</span><span class="n">sessionBus</span><span class="p">().</span><span class="n">connect</span><span class="p">(</span><span class="s">"org.<span class="hl">freedesktop.PowerManagement"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"/org/kde/</span>Solid<span class="hl">/</span>PowerManagement<span class="hl">/Actions/SuspendSession"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"org.</span>kde<span class="hl">.</span>Solid<span class="hl">.</span>PowerManagement<span class="hl">.Actions.SuspendSession</span>"</span><span class="p">,</span> <span class="s">"resumingFromSuspend"</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">resumedFromSuspend</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I doubt these actions exist on the FDO object, Dario?</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110135/diff/2/?file=140644#file140644line59" style="color: black; font-weight: bold; text-decoration: underline;">plasma/generic/dataengines/time/timeengine.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">TimeEngine::~TimeEngine()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dbus</span><span class="p">.</span><span class="n">connect</span><span class="p">(</span><span class="s">"org.<span class="hl">kde.</span>Solid<span class="hl">.</span>PowerManagement<span class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"/org/kde/</span>Solid<span class="hl">/</span>PowerManagement<span class="hl">"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"org.kde.Solid.PowerManagement</span>"</span><span class="p">,</span> <span class="s">"resumingFromSuspend"</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">clockSkewed</span><span class="p">()));</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">dbus</span><span class="p">.</span><span class="n">connect</span><span class="p">(</span><span class="s">"org.<span class="hl">freedesktop.PowerManagement"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"/org/kde/</span>Solid<span class="hl">/</span>PowerManagement<span class="hl">/Actions/SuspendSession"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="s"><span class="hl">"org.kde.</span>Solid<span class="hl">.</span>PowerManagement<span class="hl">.Actions.SuspendSession</span>"</span><span class="p">,</span> <span class="s">"resumingFromSuspend"</span><span class="p">,</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">clockSkewed</span><span class="p">()));</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is weird... why would you change this?</pre>
</div>
<br />
<p>- Lukáš</p>
<br />
<p>On April 23rd, 2013, 9:12 p.m. CEST, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Solid, Dario Freddi, and Sebastian Kügler.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated April 23, 2013, 9:12 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Suspend/hibernate are now longer are part of
org.kde.Solid.PowerManagement interface, so adjusting to new one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, actions work now.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=318737">318737</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/randr/module/randrmonitor.cpp <span style="color: grey">(5a719a4)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(e54c216)</span></li>
<li>ksmserver/shutdowndlg.cpp <span style="color: grey">(247c877)</span></li>
<li>plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: grey">(4e83c37)</span></li>
<li>plasma/generic/dataengines/powermanagement/powermanagementjob.cpp <span style="color: grey">(6f90006)</span></li>
<li>plasma/generic/dataengines/time/timeengine.cpp <span style="color: grey">(2f69e8f)</span></li>
<li>plasma/generic/runners/powerdevil/PowerDevilRunner.cpp <span style="color: grey">(74eb36d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110135/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>