<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108912/">http://git.reviewboard.kde.org/r/108912/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides the spaces (reviewboard paints a big red square for them xD) everything seems ok, at least code wise.
I have yet to learn all the changes in BlueZ so I can't really evaluate whether your changes are correct or not, but from what I have read (in your code and in BlueZ documentation) everything looks fine.
Please, commit this into a branch within the libbluedevil repository (bluez5 ?) so we can prepare everything for a release.
This is a little sheet we use before each release to make sure that everything works:
http://community.kde.org/Solid/Projects/BlueDevil/Tests
As soon as all works with bluez5 we can make a first release.
Again, really great job ! I'm really looking forward at BlueDevil/libbluedevil 2.0</pre>
<br />
<p>- Àlex</p>
<br />
<p>On March 16th, 2013, 3:34 p.m. UTC, Daniel Schaal wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bluedevil.</div>
<div>By Daniel Schaal.</div>
<p style="color: grey;"><i>Updated March 16, 2013, 3:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Use DBus ObjectManager to get Adapter/Devices (inspired by solid's udisks2 backend)
* remove cached properties, directly use DBus properties
* add unpairedDeviceFound signal to Adapter
* move [un]registerAgent to Manager
* Update DBus interfaces for Bluez 5
* Remove default adapter methods.
git repo available on http://quickgit.kde.org/?p=clones/libbluedevil/schaal/libbluedevil.git
References:
http://www.bluez.org/bluez-5-api-introduction-and-porting-guide/
https://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">adaptertest:
* added/removed a (virtual) adapter
* started/stopped bluetoothd
bluedeviltest:
* scanning for a device and removing a device
pairing wizard from bluedevil:
* pairing a headset device</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5fb5039bc88ab7f53e2c3f0b0ba066892efbbda3)</span></li>
<li>bluedevil/CMakeLists.txt <span style="color: grey">(766d603b8dec09bef31fcee9cba7eb4ef7e3d5f4)</span></li>
<li>bluedevil/bluedevil.h <span style="color: grey">(798068b76e69c70ec3b208cfdbf4fad532862aea)</span></li>
<li>bluedevil/bluedeviladapter.h <span style="color: grey">(65e5a4babdb13068f4f371aca818aa99b5a1921e)</span></li>
<li>bluedevil/bluedeviladapter.cpp <span style="color: grey">(740ccb796baee1e05c6677243a30e9330e207017)</span></li>
<li>bluedevil/bluedevildbustypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluedevildevice.h <span style="color: grey">(003aa027b29f7a98bbb01d60dc626ed4b02588a9)</span></li>
<li>bluedevil/bluedevildevice.cpp <span style="color: grey">(dafc130af7ab6fbf66dd33c0508ae78d71bde9aa)</span></li>
<li>bluedevil/bluedevilmanager.h <span style="color: grey">(0386b8ef187ad0cd06f51436f8d4feb916ca74e3)</span></li>
<li>bluedevil/bluedevilmanager.cpp <span style="color: grey">(e6344320783895536aa1fea4d71f58fcc4f3cf41)</span></li>
<li>bluedevil/bluez/bluez-adapter.xml <span style="color: grey">(5535fff2d00f79e6bb12d4f7d77b40a16d5fe9ee)</span></li>
<li>bluedevil/bluez/bluez-device.xml <span style="color: grey">(74ac0816cb4058d08024da93fe27616e138f8294)</span></li>
<li>bluedevil/bluez/bluez-manager.xml <span style="color: grey">(fe7fcbe5f750c0f065c8dff98bf777f7b3d2ebf2)</span></li>
<li>bluedevil/bluez/doc/adapter-api.txt <span style="color: grey">(6098c765e33ff085093f26ce84df2aee07315f40)</span></li>
<li>bluedevil/bluez/doc/agent-api.txt <span style="color: grey">(d8d35c05a923b7ccb23370f17e9aeff516233807)</span></li>
<li>bluedevil/bluez/doc/audio-api.txt <span style="color: grey">(e7991f336f76e151c645d422a6abd4764623c8fd)</span></li>
<li>bluedevil/bluez/doc/bluez-docs.xml <span style="color: grey">(74a8bd1918689671b73c54aa1bbad5f2241ff3be)</span></li>
<li>bluedevil/bluez/doc/control-api.txt <span style="color: grey">(1a42846ad096f8a0caa5267627ff03382e762563)</span></li>
<li>bluedevil/bluez/doc/device-api.txt <span style="color: grey">(b8182997392d2d66a2e60fdcf929502056e468f1)</span></li>
<li>bluedevil/bluez/doc/gtk-doc.make <span style="color: grey">(354ffb7c66c4e6151ed126f63320d03f7b21d6b3)</span></li>
<li>bluedevil/bluez/doc/hfp-api.txt <span style="color: grey">(93251e83f4435c30408eba1c862b116735d8388e)</span></li>
<li>bluedevil/bluez/doc/input-api.txt <span style="color: grey">(7c3a4b23e542dbd70ebf5d314cdc971726407f82)</span></li>
<li>bluedevil/bluez/doc/manager-api.txt <span style="color: grey">(d2c1cafe46b6535efd6c2d9ebf968feba122e25b)</span></li>
<li>bluedevil/bluez/doc/network-api.txt <span style="color: grey">(eca60d4f3c683e4de3c38dad4f458d5c3d99b0ac)</span></li>
<li>bluedevil/bluez/doc/node-api.txt <span style="color: grey">(3ae4deef9e398aaf81844be2c2e39394a2ccd9e2)</span></li>
<li>bluedevil/bluez/doc/serial-api.txt <span style="color: grey">(5f9bd5f2ccd23b1b37e066b553b5ff60c271ceb7)</span></li>
<li>bluedevil/bluez/doc/service-api.txt <span style="color: grey">(5c8c7f37280301162abf4dc09800bd9f5a2bd255)</span></li>
<li>bluedevil/bluez/doc/version.xml.in <span style="color: grey">(d78bda93422ecbbca8caf772f7b37f8fe3b254e9)</span></li>
<li>bluedevil/bluez/org.bluez.Adapter1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.bluez.AgentManager1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.bluez.Device1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.freedesktop.DBus.ObjectManager.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/bluez/org.freedesktop.DBus.Properties.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>bluedevil/test/adaptertest.h <span style="color: grey">(0521fe165ae34aaf86f7e61149452389ad9bb644)</span></li>
<li>bluedevil/test/adaptertest.cpp <span style="color: grey">(fd1ab818d3318e75b88c1e94e7f09fc8aa9f6cee)</span></li>
<li>bluedevil/test/bluedeviltest.cpp <span style="color: grey">(2d3d0e2cd5d9f986802b2c3728bdf013fd7b84b0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108912/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>