<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109384/">http://git.reviewboard.kde.org/r/109384/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 14th, 2013, 10:40 a.m. UTC, <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please also test with special media, like blank and audio CDs. Thanks for the work!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't touch code that handles other disk types, as only video disk detection caused problems. And I don't have audio cds, sorry. But other people tested it and reported that everything works fine.</pre>
<br />
<p>- Alexander</p>
<br />
<p>On March 14th, 2013, 3:31 a.m. UTC, Alexander Mezin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Lukáš Tinkl.</div>
<div>By Alexander Mezin.</div>
<p style="color: grey;"><i>Updated March 14, 2013, 3:31 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">While bug 261552 marked as fixed, optical drive spin-ups still happen more frequent than needed. Also, if there is a corrupted optical disk in the drive, a long delay happens when opening new file manager window (bug 306426).
This patch introduces a daemon that reads optical disks and remembers results, so disk access happens only once, usually right after new disk is inserted.
This is for udisks2 backend, but should also work with udisks 1. The daemon doesn't contain any backend-specific code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tested it on top of kdelibs-4.10.1. Video DVDs are recognized correctly.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=261552">261552</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=306426">306426</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/CMakeLists.txt <span style="color: grey">(ab3f554)</span></li>
<li>solid/solid/backends/udisks2/udisksopticaldisc.h <span style="color: grey">(0cdcc66)</span></li>
<li>solid/solid/backends/udisks2/udisksopticaldisc.cpp <span style="color: grey">(23a4fc1)</span></li>
<li>solid/solid/diskscan/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/diskscan/diskscanner.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/diskscan/diskscanner.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/diskscan/diskscannertask.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/diskscan/diskscannertask.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/diskscan/org.kde.Solid.DiskScanner.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/diskscan/soliddiskscan.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109384/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>