<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108894/">http://git.reviewboard.kde.org/r/108894/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2013, 2:03 p.m. UTC, <b>Sebastian Kügler</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not happy with it, UI-wise, for the following reasons:
- the OSD is an indicator of the user changing a setting, not a status display
- the feature is entirely hidden, meaning that nobody will know it, notice it, and use it
- It solves a fringe case
I see how it can be useful to solve a very specific usecase, but it's not a feature that should be available to the general public (after all, being able to see the battery is also only one keystroke away)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> - the OSD is an indicator of the user changing a setting, not a status display
The Amarok OSD is as well yet still you can trigger it anytime anywhere
> - the feature is entirely hidden
Probably but the keystroke for Amarok's OSD is also hidden and that you are able to configure a shortcut to show a widget isn't that easily discoverable either
> - It solves a fringe case
Probably</pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On February 10th, 2013, 10:54 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2013, 10:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This draft patch is for adding a Battery OSD the user can trigger using Meta+B any time to show the battery percentage anytime without disrupting the workflow. My usecase for this is when I am watching fullscreen flash videos, they cause quite some drain on battery, but when I want to look how much battery is left, I have to either leave fullscreen and peak, or (as I do) press some shortcut assigned to the battery widget. Both will cause the fullscreen to exit. Even more useful when playing a fullscreen game that you don't want (or can) to leave.
This adds a little OSD similar to the brightness OSD that shows the battery percentage when the user presses Meta+B.
This patch is draft because I first wanted to know your opinion on this before I start completing it (ie. showing the battery icon in the same way the battery widget does), atm it's the brightness icon.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When I press Meta+B I get an OSD showing my current battery percentage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/powerdevilcore.h <span style="color: grey">(dd5d674)</span></li>
<li>powerdevil/daemon/powerdevilcore.cpp <span style="color: grey">(6be6a8b)</span></li>
<li>powerdevil/daemon/actions/bundled/brightnesscontrol.cpp <span style="color: grey">(323905d)</span></li>
<li>powerdevil/daemon/actions/bundled/keyboardbrightnesscontrol.cpp <span style="color: grey">(8249b17)</span></li>
<li>powerdevil/daemon/brightnessosdwidget.h <span style="color: grey">(40166d4)</span></li>
<li>powerdevil/daemon/brightnessosdwidget.cpp <span style="color: grey">(1474018)</span></li>
<li>powerdevil/daemon/powerdevilbackendinterface.h <span style="color: grey">(00ccada)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108894/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/10/batteryosd.png">Battery OSD</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>