<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106795/">http://git.reviewboard.kde.org/r/106795/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 14th, 2013, 11:48 a.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In correspondance with http://mail.kde.org/pipermail/plasma-devel/2013-January/023423.html</pre>
</blockquote>
<p>On January 22nd, 2013, 7:18 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">@Oliver
How do we proceed on this?
Whithout dpms working neither https://git.reviewboard.kde.org/r/108416/ nor https://git.reviewboard.kde.org/r/108417/ make any sense at all, so do you want to move this out of powerdevil altogether (towards solid) and not be used before at all or just not be used in terms of https://git.reviewboard.kde.org/r/108417/ or include it in 4.10 or 4.11?
(As mentioned, i'm foreign here, so i'll stick to the preferences of the maintainers and/or regular commiters - just cleaning up my git history ;-)</pre>
</blockquote>
<p>On January 23rd, 2013, 5:31 p.m. UTC, <b>Oliver Henshaw</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need to put together a counter-proposal to https://git.reviewboard.kde.org/r/108417/ for a start. Review 108416 is likely to be useful in any case.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Review 108416 is likely to be useful in any case.
What would be the sense in exporting a functionality which does not work and that is not used by client code either.
-> Discarded that.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On October 11th, 2012, 1:15 p.m. UTC, Oliver Henshaw wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Oliver Henshaw.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2012, 1:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoid race during button-triggered DPMS
core->onResumeFromSuspend calls SimulateUserActivity from the
screensaver dbus interface. This seems to race with the subsequent call
to DPMSForceLevel so that the screen re-wakes but 'xset -q' thinks it is
off and timed dpms activation is disabled (this may be hardware dependent
- see https://bugzilla.redhat.com/show_bug.cgi?id=864074 for details.)
PowerDevil::Core::onResumeFromSuspend used to (optionally) lock the
screen but this changed in a3b0089130145ad15173d1c14ab8a672b93aea65 -
now the call is useless at best.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set powerbutton to turn off screen and tested that it works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp <span style="color: grey">(a16bf7ee254b9a40c6f033c93e5ca63226469e6e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106795/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>