<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108351/">http://git.reviewboard.kde.org/r/108351/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 11th, 2013, 11:55 p.m. UTC, <b>Dan Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the 'primary' update, I was considering a different approach than just a bool, possibly an enum { SetPrimary, UnsetPrimary, NoChange } so that you could call XRandROutput::update(NoChange) from crtcChanged() and XRandROutput::update((output == primary) ? SetPrimary : UnsetPrimary) from outputChanged(). I'll try to do this during weekend before tagging :-)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, since this is internal api we shouldn't bikeshed on it.</pre>
<br />
<p>- Àlex</p>
<br />
<p>On January 11th, 2013, 3:43 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Dan Vrátil.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2013, 3:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Basically call XRandR::updateOutput(RROUtput) on every XRandR::updateCrtc(RRCrtc)
This is a little bit inneficient since we don't have a way of updating an output without checking if the primary screen changed (that can't happen in a crtc update) but anyway a minor thing imho.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/xrandr/xrandr.cpp <span style="color: grey">(0113671)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108351/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>