<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107940/">http://git.reviewboard.kde.org/r/107940/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b309874669283054825f24194bdafff1e776a0ce by Lamarque V. Souza to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On January 9th, 2013, 9:10 p.m., Lamarque Vieira Souza wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid, Àlex Fiestas and Dan Vrátil.</div>
<div>By Lamarque Vieira Souza.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2013, 9:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change in XRandROutput::edid() allows us to use "if (edid->isValid())" instead of "if (edid && edid->isValid())". I think the former is cleaner.
The change in XRandROutput::updateModes() selects the first preferred mode found instead of the last one. At least in my notebook the first preferred mode has higher resolution, probably that is also valid for all modes returned by XRandR API.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in my notebook. The change in XRandROutput::edid() is part of a crash fix for kscreen. The change in XRandROutput::updateModes() fixes a problem in my notebook's lcd, which includes several preferred modes and the last mode is the one with lower resolution.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312236">312236</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=312951">312951</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/xrandr/xrandroutput.cpp <span style="color: grey">(dc2555b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107940/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>