<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106864/">http://git.reviewboard.kde.org/r/106864/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2012, 4:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed duplicate screenshot.
Checked and yes, this patch also causes the battery plasmoid config dialog to be properly initially sized.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It really took me two hours to find this bug but now I have found it: Seems like a bug in Qt or in the Oxygen theme: When there is a QScrollArea inside a QTabBar, and this QScrollArea contains a generated widget applied by setWidget, this widget in the first tab of the tab list (and the default selected one) are not opaque, making the gradient invisible. (Sorry, could not describe better).
After I found out that that ScrollArea is not needed at all but the QTabBar provides scrollbars by itself, I removed all that stuff, and just added a QGridLayout (first thing I could think of that could hold widgets) to hold our EditWidget. Now all the backgrounds are correct.
And this patch also has a little positive side-effect: The config dialog of the battery plasmoid is now initially sized properly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Opened the dialog, the "ON AC Power" tab has proper background. When resizing the dialog, scroll bars appear. It also works when the tabbar is hidden (when no batteries present - just saw: the battery detection code could be simplified like in the other KCM (hasBattery rather than batteryCount)).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=307648">307648</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/kcmodule/profiles/EditPage.cpp <span style="color: grey">(95a98d9)</span></li>
<li>powerdevil/kcmodule/profiles/profileEditPage.ui <span style="color: grey">(cc99e9b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106864/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106864/s/772/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/15/pmkcmfixed_400x100.png" style="border: 1px black solid;" alt="Proof screenshot :)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>