<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106790/">http://git.reviewboard.kde.org/r/106790/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Dario Freddi.</div>
<div>By Alberto Villa.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch should bring FreeBSD to feature parity with Linux on brightness management; it uses acpi_video(4) interface. The code was inspired by Junk-uk Kim's following patch: https://bugs.freedesktop.org/show_bug.cgi?id=24765
I've used a generic #ifdef USE_SYSCTL to make it easy for other BSDs to add support for their system. initUsingSysctl(), m_device and m_levels are always defined to avoid spoiling backlighthelper.h with #ifdefs and definitions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine on FreeBSD 10-CURRENT, even with my half broken ACPI (no LCD screen detected); shortcuts work, plasmoid slider works, power profiles work, and display dimming works as well (and is very welcome on my laptop). I've monitored brightness events via kded output, and everything works as expected (values rounding included).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/backends/upower/backlighthelper.h <span style="color: grey">(fe659e7)</span></li>
<li>powerdevil/daemon/backends/upower/backlighthelper.cpp <span style="color: grey">(86b359a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106790/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>