<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105432/">http://git.reviewboard.kde.org/r/105432/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just my 2 cents:
This piece of API does not seem to belong to the dataengine.
I would rather consider inclusion in the solid API; I vaguely recall having read (or written) some similar code somewhere else, so
it would definitely make sense to put it in the libs.
Best Regards</pre>
<br />
<p>- Jacopo De</p>
<br />
<p>On July 5th, 2012, 6:44 a.m., Andriy Gapon wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Solid.</div>
<div>By Andriy Gapon.</div>
<p style="color: grey;"><i>Updated July 5, 2012, 6:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the code in SolidDeviceEngine::populateDeviceData sets volume's Removable property in straightforward fashion:
- tries to cast volume's (immediate) parent device to Solid::StorageDrive
- if that succeeds, checks isHotpluggable() and isRemovable() properties of the parent
The problem is that there could be intermediate devices in solid device hierarchy between the volume and its Solid::StorageDrive ancestor, for example partition-type devices.
The proposed code walks up the hierarchy to try harder to find Solid::StorageDrive ancestor of a given device.
BTW, I think that getAncestorOfType() helper function introduced in the proposed change can be useful for other code too, so it might make sense to nominate it for inclusion into Solid API.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/dataengines/soliddevice/soliddeviceengine.cpp <span style="color: grey">(608da25)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105432/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>