<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101160/">http://git.reviewboard.kde.org/r/101160/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit bdf3cc8ac328e907e88de36d698bba6a7f0e2c7f by Ozan Çağlayan.</pre>
<br />
<p>- Commit</p>
<br />
<p>On April 20th, 2011, 1:36 p.m., Ozan Çağlayan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid, Alex Fiestas and Lukáš Tinkl.</div>
<div>By Ozan Çağlayan.</div>
<p style="color: grey;"><i>Updated April 20, 2011, 1:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When you *first* mount an encrypted container and enter the passphrase correctly, Dolphin is launched through SolidUiServer with:
kioclient exec %f
after the setupDone() signal is emitted. But the signal is emitted right after the async D-Bus call which mounts the slave filesystem,
causing the %f to be expanded to an empty string returned by UDisksStorageAccess::filePath(). This causes Dolphin to show the Home directory
instead of the just-mounted filesystem.
Encapsulate the "signal emitting" in else {} block to cure this problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on KDE 4.6.2 with
- an encrypted container
- a normal usb flash disk
and works OK.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=271156">271156</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/udisks/udisksstorageaccess.cpp <span style="color: grey">(7dd25ea)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101160/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>