<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/100815/">http://git.reviewboard.kde.org/r/100815/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good.</pre>
 <br />







<p>- Kevin</p>


<br />
<p>On March 25th, 2011, 11:15 a.m., Mario Bensi wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Solid.</div>
<div>By Mario Bensi.</div>


<p style="color: grey;"><i>Updated March 25, 2011, 11:15 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Add the NetworkShare interface to determine the network protocol used.
- Use this interface in fstab backend to determine if we have a nfs or 
  smb mount point.
</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>solid/solid/CMakeLists.txt <span style="color: grey">(46adea8)</span></li>

 <li>solid/solid/backends/fakehw/fakedevice.cpp <span style="color: grey">(94455ed)</span></li>

 <li>solid/solid/backends/fstab/fstabdevice.cpp <span style="color: grey">(efc085d)</span></li>

 <li>solid/solid/backends/fstab/fstabmanager.cpp <span style="color: grey">(68e8d8b)</span></li>

 <li>solid/solid/backends/fstab/fstabnetworkshare.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>solid/solid/backends/fstab/fstabnetworkshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>solid/solid/backends/hal/haldevice.cpp <span style="color: grey">(56823f6)</span></li>

 <li>solid/solid/backends/hal/haldeviceinterface.h <span style="color: grey">(240017b)</span></li>

 <li>solid/solid/backends/udisks/udisksdeviceinterface.h <span style="color: grey">(42a88a8)</span></li>

 <li>solid/solid/backends/upower/upowerdeviceinterface.h <span style="color: grey">(6608ab3)</span></li>

 <li>solid/solid/backends/wmi/wmideviceinterface.h <span style="color: grey">(99437e5)</span></li>

 <li>solid/solid/backends/wmi/wmimanager.cpp <span style="color: grey">(41c7274)</span></li>

 <li>solid/solid/device.cpp <span style="color: grey">(54135d8)</span></li>

 <li>solid/solid/deviceinterface.h <span style="color: grey">(c04bbf4)</span></li>

 <li>solid/solid/deviceinterface.cpp <span style="color: grey">(375ae37)</span></li>

 <li>solid/solid/ifaces/networkshare.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>solid/solid/ifaces/networkshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>solid/solid/networkshare.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>solid/solid/networkshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>solid/solid/networkshare_p.h <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/100815/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>