<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100815/">http://git.reviewboard.kde.org/r/100815/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See comments below. Also for some reason you adjusted the other backends, except the UPnP one, it should need to be updated as well.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100815/diff/3/?file=10797#file10797line111" style="color: black; font-weight: bold; text-decoration: underline;">solid/solid/deviceinterface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QString Solid::DeviceInterface::typeDescription(Type type)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">111</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">QObject</span><span class="o">::</span><span class="n">tr</span><span class="p">(</span><span class="s">"NetworkShare Interface"</span><span class="p">,</span> <span class="s">"Network Share device type"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should simply be "Network Share", not "NetworkShare Interface" IMO.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100815/diff/3/?file=10800#file10800line40" style="color: black; font-weight: bold; text-decoration: underline;">solid/solid/networkshare.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Solid</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> * network access.</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should carry "@since 4.7"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100815/diff/3/?file=10800#file10800line45" style="color: black; font-weight: bold; text-decoration: underline;">solid/solid/networkshare.h</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Solid</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">45</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">ShareType</span> <span class="n">type</span> <span class="n">READ</span> <span class="n">type</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please add the URL or ID property as discussed today over IRC with Sebatian.</pre>
</div>
<br />
<p>- Kevin</p>
<br />
<p>On March 9th, 2011, 10:22 a.m., Mario Bensi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Mario Bensi.</div>
<p style="color: grey;"><i>Updated March 9, 2011, 10:22 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Add the NetworkShare interface to determine the network protocol used.
- Use this interface in fstab backend to determine if we have a nfs or
smb mount point.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/CMakeLists.txt <span style="color: grey">(46adea8)</span></li>
<li>solid/solid/backends/fakehw/fakedevice.cpp <span style="color: grey">(94455ed)</span></li>
<li>solid/solid/backends/fstab/fstabdevice.cpp <span style="color: grey">(efc085d)</span></li>
<li>solid/solid/backends/fstab/fstabmanager.cpp <span style="color: grey">(68e8d8b)</span></li>
<li>solid/solid/backends/fstab/fstabnetworkshare.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/fstab/fstabnetworkshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/backends/hal/haldevice.cpp <span style="color: grey">(56823f6)</span></li>
<li>solid/solid/backends/hal/haldeviceinterface.h <span style="color: grey">(240017b)</span></li>
<li>solid/solid/backends/udisks/udisksdeviceinterface.h <span style="color: grey">(42a88a8)</span></li>
<li>solid/solid/backends/upower/upowerdeviceinterface.h <span style="color: grey">(6608ab3)</span></li>
<li>solid/solid/backends/wmi/wmideviceinterface.h <span style="color: grey">(99437e5)</span></li>
<li>solid/solid/backends/wmi/wmimanager.cpp <span style="color: grey">(41c7274)</span></li>
<li>solid/solid/device.cpp <span style="color: grey">(54135d8)</span></li>
<li>solid/solid/deviceinterface.h <span style="color: grey">(c04bbf4)</span></li>
<li>solid/solid/deviceinterface.cpp <span style="color: grey">(375ae37)</span></li>
<li>solid/solid/ifaces/networkshare.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/ifaces/networkshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/networkshare.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/networkshare.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid/solid/networkshare_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100815/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>