<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100768/">http://git.reviewboard.kde.org/r/100768/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turns out Nikhil committed a similar patch last night. Please close this request and the corresponding BR. Thanks for the effort and pointing out the issue though.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On March 2nd, 2011, 5:40 p.m., Christopher Blauvelt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Kevin Ottens.</div>
<div>By Christopher Blauvelt.</div>
<p style="color: grey;"><i>Updated March 2, 2011, 5:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The HUPnP backend does not compile with the most up-to-date version (0.9) of HUPnP due to API changes. The ~HAsyncOp() function was made a pure virtual function preventing direct use of the class. The class used was changed to HClientActionOp. Additionally, the setUserData and userData functions were removed from HAsyncOp. These functions were used to pass input arguments for previously invoked functions. HClientActionOp provides a method to reference these input parameters.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">None. What facilities exist to test UPnP devices?</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=267283">267283</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/upnp/upnpinternetgateway.h <span style="color: grey">(35f0c00)</span></li>
<li>solid/solid/backends/upnp/upnpinternetgateway.cpp <span style="color: grey">(527efe8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100768/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>