<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6119/">http://svn.reviewboard.kde.org/r/6119/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 3rd, 2011, 6:50 p.m., <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No go API wise IMO. Only the signal should be in the public API and that's it, anything else is showing implementation details to the outside I think.</pre>
</blockquote>
<p>On January 3rd, 2011, 6:54 p.m., <b>Dario Freddi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the main rationale behind it is that the signal can be indeed not be emitted at all - and for the application it might be interested to know it. On a second thought, though, this seem to be useless as the app would simply ignore the signal - so avoiding to emit it would be more than fine. I'll update the patch. Btw, I suppose this is no go for 4.6, isn't it?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, too late for 4.6, we're waaay passed the API freeze unfortunately. I would have loved to have it in 4.6 otherwise.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On December 15th, 2010, 2:05 p.m., Dario Freddi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Kevin Ottens.</div>
<div>By Dario Freddi.</div>
<p style="color: grey;"><i>Updated 2010-12-15 14:05:42</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a method to connect to the resumingFromSuspend signal provided by the KDE Power Management system. In addition, I added a method to detect its availability, to prevent applications from relying on it when it's not available.
P.S.: All of the new functions are @since 4.6, but I don't really know if it is 4.6 material. Kevin, I leave the decision to you.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/solid/solid/powermanagement.h <span style="color: grey">(1206691)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/powermanagement.cpp <span style="color: grey">(1206691)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/powermanagement_p.h <span style="color: grey">(1206691)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6119/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>