<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5993/">http://svn.reviewboard.kde.org/r/5993/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Pino Toscano.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a first implementation of DvbInterface for the udev backend.
Allows devices of subsystem "dvb" among the ones that the udev backend shows, and for them it provides a DvbInterface implementation (which is basically copied from the HAL one, with s/hal/udev/ and the right property to query for the device name, so I will do svn cp for it).
What is missing is an icon and a description for dvb devices, mostly because of the string freeze. (At least to me, HAL returns a "DVB Device" string for all the dvb devices reported, so in case it would be the same for the udev backend.)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kaffeine sees and recognizes my DVB device, allowing me to use it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/solid/solid/CMakeLists.txt <span style="color: grey">(1201550)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp <span style="color: grey">(1201550)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdvbinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp <span style="color: grey">(1201550)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5993/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>