<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5892/">http://svn.reviewboard.kde.org/r/5892/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Rafael Fernández López.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated 2010-11-25 22:34:50.083422</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made suggested changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement support for all attributes of the Processor interface when using UDev.
With this patch, the udev backend does better than the hal one (notably, with linux 2.6.36, HAL's reporting of the throttling ability of a processor will break, as /proc/acpi/CPUX/info is removed in that kernel version; also, HAL does not report the processor vendor).
It might be good to do some caching of values, since there is a lot of opening and parsing files (although the opening and reading part should be fast on virtual filesystems, and there isn't a whole lot of text to parse).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Reports information correctly on my computer.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=253667">253667</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/solid/solid/CMakeLists.txt <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/shared/udevqt.h <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/shared/udevqtdevice.cpp <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/cpuinfo.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.h <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.h <span style="color: grey">(1199450)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.cpp <span style="color: grey">(1199450)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5892/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>