<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5894/">http://svn.reviewboard.kde.org/r/5894/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good, please commit</pre>
<br />
<p>- Lukáš</p>
<br />
<p>On November 18th, 2010, 1:29 a.m., Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Lukáš Tinkl.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated 2010-11-18 01:29:46</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If UDevManager is instantiated, then UDisks sends a DeviceAdded signal, then someone calls a method that makes use of deviceCache(), the device cache will never be populated.
The reason is that the DeviceAdded signal will add the new device to the empty cache, then deviceCache() will assume the cache has been populated, as it is not empty.
This patch simply makes sure that DeviceAdded (and DeviceChanged) don't add anything to an empty cache. If the cache is empty, deviceCache() will populate it anyway. The signals are still forwarded, however, as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksmanager.cpp <span style="color: grey">(1198261)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5894/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>