<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5853/">http://svn.reviewboard.kde.org/r/5853/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated 2010-11-16 02:55:10.215254</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just updated the description to be easier to understand.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds support to the Solid udev backend for Portable Media Players. Providing the user has media-player-info installed, the functionality should be identical to the hal backend in the case where libmtp is not installed.
libmtp provides HAL with extra information about the media devices it can deal with. There is no clear way to access that information without HAL - I've filed bugs with media-player-info and libmtp about that, so we'll see where that goes.
The other issue (as may be apparent from the code) is that gphoto2's udev rules interfere with media-player-info's rules by also setting ID_MEDIA_PLAYER. media-player-info stores useful information under this key, while gphoto2 just sets it to 1 if it recognises the device. There are 14 overlapping devices currently, and if gphoto2's rules are parsed after media-player-info's rules, the media-player-info details will be overwritten for these devices. Again, I've filed bugs with the relevant projects about this.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">solid-hardware lists "storage" as a supported protocol for my Sansa Clip+ when it's operating in MSC (storage) mode.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=253671">253671</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/solid/solid/CMakeLists.txt <span style="color: grey">(1196931)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp <span style="color: grey">(1196931)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp <span style="color: grey">(1196931)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevportablemediaplayer.h <span style="color: grey">(1196931)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/backends/udev/udevportablemediaplayer.cpp <span style="color: grey">(1196931)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/xdgbasedirs.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/solid/solid/xdgbasedirs_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5853/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>