[Kde-hardware-devel] Review Request 116527: Properly check logind suspend-related interfaces
Timothée Ravier
timothee.romain.ravier at gmail.com
Sun Mar 2 02:06:14 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116527/
-----------------------------------------------------------
Review request for Solid.
Repository: kde-workspace
Description
-------
Properly check logind suspend-related interfaces by calling DBus methods, getting properties and checking for errors. This is recommended by upstream:
http://lists.freedesktop.org/archives/systemd-devel/2014-February/017403.html
http://lists.freedesktop.org/archives/systemd-devel/2014-February/017452.html
Replace logic introduced in:
https://git.reviewboard.kde.org/r/114393/
https://git.reviewboard.kde.org/r/115271/
This also removes the systemd and upstart version checks.
Diffs
-----
powerdevil/daemon/backends/upower/dbus/org.freedesktop.login1.xml PRE-CREATION
powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml dc7ae42
powerdevil/daemon/BackendConfig.cmake 41c8812
powerdevil/daemon/backends/upower/login1suspendjob.h e1c2ff4
powerdevil/daemon/backends/upower/login1suspendjob.cpp 54371c8
powerdevil/daemon/backends/upower/powerdevilupowerbackend.h c6563b0
powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 94b20f1
Diff: https://git.reviewboard.kde.org/r/116527/diff/
Testing
-------
All tests were done running systemd 210 on Arch Linux:
* With kdebase-workspace 4.11.6-2 from official repositories, suspend is not available;
* With kdebase-workspace git branch KDE/4.11 with commit 5dc2b9a5c09d95ba9a17ac00056213082feb8d90 reverted, suspend is not available;
* With kdebase-workspace git branch KDE/4.11 with commit 5dc2b9a5c09d95ba9a17ac00056213082feb8d90, suspend is available;
* With kdebase-workspace git branch KDE/4.11 with the patch, suspend is available;
Thanks,
Timothée Ravier
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140302/e66845d8/attachment.html>
More information about the Kde-hardware-devel
mailing list