<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128952/">https://git.reviewboard.kde.org/r/128952/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 20th, 2016, 10:54 a.m. UTC, <b>Boudhayan Gupta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128952/diff/1/?file=477155#file477155line89" style="color: black; font-weight: bold; text-decoration: underline;">src/ExportManager.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">89</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">scale</span> <span class="o">=</span> <span class="n">qRound</span><span class="p">(</span><span class="n">qApp</span><span class="o">-></span><span class="n">primaryScreen</span><span class="p">()</span><span class="o">-></span><span class="n">logicalDotsPerInch</span><span class="p">()</span> <span class="o">/</span> <span class="mf">96.0</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm a little hesitant about hardcoding a 96.0 dpi value. There's a scale factor somewhere (QScreen::devicePixelRatio() I believe) - just divide?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">devicePixelRatio() isn't what you want. This is essentially just the value of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QT_SCREEN_SCALE_FACTORS</code>, which is for many HiDPI users "1". In otherwords, this represents the scaling ratio for things like cell padding and window size defaults. The real thing we want is to know how things are in terms of the X server's DPI, because this is what influences everything else. And for that we must use the logical DPI. The 96 value isn't some horrible hardcoded value. Rather, the "x" notation of scaling is defined in terms of that. It would be a mistake to scale the image by a precise amount, because HiDPI is supposed to match classic screen sizes by whole ratios. In other words, the scaled down image will always be coherent as resolution/2 or resolution/3 or resolution/4.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, I think this is the right approach here.</p></pre>
<br />
<p>- Jason A.</p>
<br />
<p>On September 20th, 2016, 2:27 a.m. UTC, Jason A. Donenfeld wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics and Boudhayan Gupta.</div>
<div>By Jason A. Donenfeld.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2016, 2:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
spectacle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some people use "retina displays" or HiDPI displays. Taking screenshots
and then posting them to the Internet is especially annoying with these
displays, because the images are twice as big in the web browser. For
those who primarily use Spectacle for taking web screenshots, this
commit adds a new option (default: off) to downscale HiDPI images to the
ordinary "1x" size so that they can be used for sharing.
In the HiDPI mode, things are usually discussed in terms of "x", where
each "x" is actually 96 DPI. This automatic feature simply sees which
"x" is closest by dividing the configured DPI by 96 and rounding.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ExportManager.cpp <span style="color: grey">(763b1f32ad42bca1b3f1d6bcb0f7f908a54b6641)</span></li>
<li>src/Gui/SettingsDialog/GeneralOptionsPage.h <span style="color: grey">(343ce037b7d1da9c9c12f0fe4eb44bf4a132d4fe)</span></li>
<li>src/Gui/SettingsDialog/GeneralOptionsPage.cpp <span style="color: grey">(1ffddd9c733d3b6f3897949ab67883886f651a69)</span></li>
<li>src/SpectacleConfig.h <span style="color: grey">(5a91f702777cde05f9608d6157d533f2e6e21347)</span></li>
<li>src/SpectacleConfig.cpp <span style="color: grey">(b812b00246421fd784d7b4646978c39fb50dfbd4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128952/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>