<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127316/">https://git.reviewboard.kde.org/r/127316/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 10th, 2016, 12:21 a.m. IST, <b>Boudhayan Gupta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I haven't read into the source code of QScreen, but the reason I wrote this using KScreen instead of QScreen was that with KScreen I was sure I was getting data about physical screens, while with QScreen something about the documentation led me to suspect that the term "screen" encompasses a logical screen, not a physical one, and in some cases may stretch across multiple physical outputs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can give this a Ship It <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">only</strong> if someone can confirm that qApp->screens() will <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">always</em> map one-to-one with physical outputs. I also strongly suspect that in Wayland we'll <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">have</em> to use KScreen anyway.</p></pre>
</blockquote>
<p>On March 20th, 2016, 4:23 p.m. IST, <b>Daniel Vrátil</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On XCB with XRandr QScreen reports the same stuff as KScreen. It is possible to configure XRandR in a way that logical screens won't map onto physical screens but then KScreen would report it like that too. I however cannot give you any testing example for I don't have multihead setup available.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On Wayland you will need to talk to compositor because you can't see other processes' windows and compositor is the only one able to do so and will probably also be the authoritative source regarding screen configuration for apps (even if backed by KScreen internally). You will have to talk to Martin and Sebas about that.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll talk to Martin and Sebas about this again, but from what I gathered during our earlier discussions, KScreen will get information about screen configuration from KWin and not the other way around; KScreen will remain a source for screen configuration data for applications.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Again, I'll get this confirmed by Sebas and Martin.</p></pre>
<br />
<p>- Boudhayan</p>
<br />
<p>On March 9th, 2016, 10:50 p.m. IST, Daniel Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics and Boudhayan Gupta.</div>
<div>By Daniel Vrátil.</div>
<p style="color: grey;"><i>Updated March 9, 2016, 10:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
spectacle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All the information needed is already provided by Qt through QScreen API, there's no need to use KScreen for that.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on single-screen setup.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(897ba01)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(e1eb3c1)</span></li>
<li>src/PlatformBackends/X11ImageGrabber.h <span style="color: grey">(e6ad26f)</span></li>
<li>src/PlatformBackends/X11ImageGrabber.cpp <span style="color: grey">(e07785a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127316/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>