<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123342/">https://git.reviewboard.kde.org/r/123342/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 5th, 2015, 3:04 p.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So firstly, including a dependency on knewstuff just to get at the KMoreTools is imho not acceptable. KMoreTools does not belong in KNewStuff. That is the entire point of frameworks: modularity, ability to choose based on specific functionality.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Otherwise, there are a few comments in the code below.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi! First of all, thanks for having a look.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">including a dependency on knewstuff just to get at the KMoreTools is imho not acceptable.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this because KNewStuff has some/many other KF5 dependencies which are not related to KMoreTools?</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KMoreTools does not belong in KNewStuff. That is the entire point of frameworks: modularity, ability to choose based on specific functionality.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If KMoreTools does not belong there, where does it? To a new framework of itsown?</p></pre>
<br />
<p>- Gregor</p>
<br />
<p>On April 15th, 2015, 9:15 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, KSnapshot and Aaron J. Seigo.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated April 15, 2015, 9:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=274928">274928</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=287663">287663</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=319901">319901</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Currently, ksnapshot's "Send To..." menu is one long list of items which can be quite large depending on the number of services and kipi-plugins installed. Note, that in the provided screenshot, the list is not that long because not all kipi plugins are ported yet.
In my daily screenshot work I always use the same set of tools and therefore it would be nice if the menu was user-configurable.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SUGGESTION:
- Only show up to 10 items in the main menu and move the rest to a new "More" submenu.
- Implement with KMoreTools (see https://git.reviewboard.kde.org/r/122910/)
- Since KMoreTools is used, the menu is automatically user configurable. See screenshots.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksnapshotsendtoactions.cpp <span style="color: grey">(a8c4ccbb72cee3bef486af417aa637c3f41de48d)</span></li>
<li>ksnapshotsendtoactions.h <span style="color: grey">(f0b4f8f6ccea15b169d7ef149645e85d89b5fe37)</span></li>
<li>ksnapshot.cpp <span style="color: grey">(ac0f2c4f44d47e1a4ae4a318382253a23ad1ed4a)</span></li>
<li>CMakeLists.txt <span style="color: grey">(cdab928a7db0e7ea29fba35880250639461dbb1e)</span></li>
<li>CMakeLists.Sources.txt <span style="color: grey">(522fc3f0f943e5c2856c76e93174d39661ca9c50)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123342/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/12/a7bf453e-0d86-46b6-a593-11a529fcdb38__current_sendto_menu.png">current situation - SendTo menu</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/12/b933c1b7-cd71-43ee-a7a0-48fb7a2567ab__1-sendt.png">Reduced SendTo menu after custom configuration</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/12/ad5eb6c4-e206-4e06-8735-c8a7f422676e__2-sendto-more.png">remaining items in "More" submenu</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/12/8d7a7368-3567-4f2b-b2f7-0a8b619549ec__3-configure-dialog-1.png">Configure Menu dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/12/cc0c6f03-7257-442c-86f5-6f4a7b8e281e__4-configure-dialog-after-reset.png">Configure Menu dialog after Reset was clicked (first 10 items in "Main section" by default)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>