<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122763/">https://git.reviewboard.kde.org/r/122763/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 18th, 2015, 11:17 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Out of curiosity: is there a reason why you discarded this request? (I am no kipi expert so I can't really assess the code changes you did)</p></pre>
</blockquote>
<p>On April 19th, 2015, 12:04 a.m. UTC, <b>Boudhayan Gupta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It didn't have a response for more than a month, and also http://quickgit.kde.org/?p=kscreengenie.git, to which I'm just copying over the cleaned up KIPI code.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kscreengenie: nice! I had a quick look and I very much like the rearranged layout which which seems more logical for the standard workflow. (The SendTo menu opens immediately which is cool. Is this because kscreengenie itself has a noticable startup delay?)</p></pre>
<br />
<p>- Gregor</p>
<br />
<p>On April 18th, 2015, 10:04 p.m. UTC, Boudhayan Gupta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KSnapshot.</div>
<div>By Boudhayan Gupta.</div>
<p style="color: grey;"><i>Updated April 18, 2015, 10:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cleans up some of the KIPI code.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Among other things, in ksnapshotsendtoactions.cpp I found code that was commented out, pragma message'd port to KF5, a line of code that went "plugin->actionCollection()->readShortcutSettings()", which upon further digging I found harked back from the KDE3.5 days, and that the API had been removed in KDElibs4. In fact, the shortcuts are already exposed inside the QAction items now, so this is gone.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also split off the createSendToActions() into two - one for KService based actions and one for KIPI. Hopefully this'll help decouple KIPI even more. From the comments in the code I get the feeling everyone wants to decouple the KIPI bits as much as possible.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds, works, including KIPI plugins. Shortcuts are exposed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kipiinterface.h <span style="color: grey">(8d866ef)</span></li>
<li>kipiinterface.cpp <span style="color: grey">(4d32647)</span></li>
<li>ksnapshotimagecollectionshared.h <span style="color: grey">(6cc6d9b)</span></li>
<li>ksnapshotimagecollectionshared.cpp <span style="color: grey">(da097f0)</span></li>
<li>ksnapshotsendtoactions.h <span style="color: grey">(f0b4f8f)</span></li>
<li>ksnapshotsendtoactions.cpp <span style="color: grey">(a8c4ccb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>