<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122553/">https://git.reviewboard.kde.org/r/122553/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it works, sure commit it, we're not releasing the frameworks branch yet so personally i don't have time to review all that goes into it a lot.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On febrer 13th, 2015, 6:09 p.m. UTC, Jeremy Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, Albert Astals Cid and Frederik Gladhorn.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated feb. 13, 2015, 6:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If QtSpeech (dev branch) is built and installed this builds and works
very well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds and runs well with qtspeech. I'll test building when qtspeech isn't installed tomorrow.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ui/tts.cpp <span style="color: grey">(6e39e20138ec3f946152f6246fedd5d8dc6482e3)</span></li>
<li>ui/pageview.cpp <span style="color: grey">(f1886d3e556cbd2fe28c675b3c3317633d14d188)</span></li>
<li>ui/tts.h <span style="color: grey">(cb990e97bf7980422cd41a64cfb783cd78bf1a6c)</span></li>
<li>part.cpp <span style="color: grey">(395b0e41386991d5a4e0eb340d088484c07f8a31)</span></li>
<li>ui/pageview.h <span style="color: grey">(4f423d72aad8a759d667ebe3011948ef9f9641bd)</span></li>
<li>conf/okular.kcfg <span style="color: grey">(55f5cdc6d497208fbe00eb2e0177b3c1e594d8b0)</span></li>
<li>CMakeLists.txt <span style="color: grey">(b9bc1f4d557344a293907b3c02e4b0a5c1f01cb7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122553/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>