<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120920/">https://git.reviewboard.kde.org/r/120920/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2014, 7:34 p.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, and please also test with KIPI_FOUND set -- Why is that not set for you?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Requires:
libkipi-dev - KDE Image Plugin Interface library -- development files</p></pre>
</blockquote>
<p>On December 3rd, 2014, 11:53 p.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am currently on the frameworks branch. As said, I wonder why KIPI_FOUND is not set although I see the following cmake output:
...
-- The following OPTIONAL packages have been found:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">KF5Kipi
X11
XCB , X protocol C<span style="color: #666666">-</span>language Binding , http<span style="color: #666666">:</span><span style="color: #408080; font-style: italic">//xcb.freedesktop.org</span>
PkgConfig
X11_XCB , Xlib<span style="color: #666666">/</span>XCB interface library , http<span style="color: #666666">:</span><span style="color: #408080; font-style: italic">//xcb.freedesktop.org</span>
...
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">build/config-ksnapshot.h contains /<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> #undef KIPI_FOUND </em>/
I did ./kdesrc-build libkipi and libkipi-dev is installed. I use KDE 4.14.3 as underlying desktop.
I currently do not fully understand the mechanism between the given cmake output and the content of the generated config-ksnapshot.h. I think they should be somehow related.</p></pre>
</blockquote>
<p>On December 4th, 2014, 7:12 a.m. UTC, <b>Kevin Funk</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ah, you're on framewors... => Please update the branch on the review-request.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding your issue: That's just been fixed:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">commit b9fcc3afc72cf7416b0a0e43cfea39ad3c7fc21a
Author: Hrvoje Senjan <a href="mailto:hrvoje.senjan@gmail.com" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">hrvoje.senjan@gmail.com</a>
Date: Thu Dec 4 04:11:55 2014 +0100</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Make KIPI_FOUND correctly set
Needs to be set before config<span style="color: #666666">-</span>ksnapshot.h is configured
</pre></div>
</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles.</p></pre>
<br />
<p>- Gregor</p>
<br />
<p>On December 4th, 2014, 10:10 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, KSnapshot, Aaron J. Seigo, and Dominik Haumann.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2014, 10:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312495">312495</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi, I also feel slightly impaired by Bug 312495 - Very slow "Send to" menu. So here is a fix.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It consists of the following changes:
1. move long-running retrieval of SendTo items to separate method
2. fillSendToActionsCache at startup but not yet async
3. move code related to SendTo actions to own class and file
(this includes the kipi code but KIPI_FOUND was not set in my dev env so thats not tested)
4. SendTo menu is built on a separate thread to speed up populating
5. delete actions in dtor
6. Create main window on stack instead of heap</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The SendTo actions are now created in QThread which is started on startup of ksnapshot.
If the user opens the SendTo menu too soon there is a message (as single menu item) that says
that the menu is still being constructed and that he/she should try a moment later.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1)
- Start ksnapshot (notice that is as fast as before)
- Immediately open SendTo menu => there is a message that the menu is not ready yet.
- Try again after 1 second: menu is populated.
- Close ksnapshot.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2)
- Start ksnapshot. Wait two seconds and then click SendTo menu
=> menu is populated right away
- Close it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">3)
Start ksnapshot. Hit the SendTo menu with insanely high button click speed.
=> No crash observed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">4)
Start ksnapshot and close it immediately.
=> No crash observed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">5) [pending]
Could no test the kipi code because KIPI_FOUND is not set yet on my environment.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(b8e665610284ae9db644e6925acae3d60e207245)</span></li>
<li>ksnapshot.h <span style="color: grey">(07100a85bbb146501ee77a9cbb9d2655edda4595)</span></li>
<li>ksnapshot.cpp <span style="color: grey">(192a0910553acf9180155ba0f409d7b15d125753)</span></li>
<li>ksnapshotsendtoactions.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>ksnapshotsendtoactions.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>main.cpp <span style="color: grey">(e7a1efb2fd8398492b96e6f21f90363d99358e12)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120920/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>