<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107555/">http://git.reviewboard.kde.org/r/107555/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit b3fa5727d56f93d14ecba8f7ed2f969dcb1d9961 by Albert Astals Cid on behalf of Adrián Chaves Fernández to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 2nd, 2012, 3:11 p.m. UTC, Adrián Chaves Fernández wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Graphics.</div>
<div>By Adrián Chaves Fernández.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2012, 3:11 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KSnapshot, when used with window regions, was ignoring the first child window (index 0). This was not a problem with usual window sizes, because the first region in the array was usually not the one targeted (probably it was one of the close/maximize/minimize buttons on the window). However, when reduzing the size of the window so that those buttons dissapeared, the main region of a window would be the first item on the array of regions (index 0), and would be ignored.
Anyway, it was just a faulty if.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I‘ve manually followed the steps in the bug report:
1. Open a window that can be resized to be very narrow - e.g., xclock
2. Decrease its width to about 80px - until the close button disappears
3. Run ksnapshot, select the "Section of window" mode, and take a screenshot.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=136142">136142</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>windowgrabber.cpp <span style="color: grey">(5de0f8b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107555/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>