<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120796/">https://git.reviewboard.kde.org/r/120796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 25th, 2014, 2:18 p.m. UTC, <b>Alexander Patrakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wrong. You should not test for PulseAudio via dbus, as the git version has module-dbus-protocol removed from the default installation. See http://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=dcb52b0844c21c7fe591ef1cfacafbda1df770f0</p></pre>
</blockquote>
<p>On October 27th, 2014, 1:45 p.m. UTC, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only other way is to check running processes (or any other ideas?). Will see what I can do.</p></pre>
</blockquote>
<p>On October 27th, 2014, 2:13 p.m. UTC, <b>Alexander Patrakov</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The very fact that you need this check indicates a layering violation or a leaky abstraction elsewhere in the stack. See https://bugzilla.gnome.org/show_bug.cgi?id=680779 (which is effectively a WONTFIX given the amount of time it exists).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, I think the correct answer is "just don't check". Checking for a process won't work, especially since you try hard to avoid spawning PulseAudio at this point. I'm afraid that you really have no choice except always assuming that PulseAudio exists together with its flat volumes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please either drop the "notification volume control" feature completely (even though it would technically be a regression on non-PulseAudio systems) or implement it by attenuating samples in software before sending them to PulseAudio or elsewhere.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for "I cannot reproduce the problem locally", I guess that you are on ubuntu or kubuntu. They disable flat volumes by default in /etc/pulse/daemon.conf for safety reasons, while the upstream default is to enable them. My opinion is that flat volumes are a security issue by themselves, but one PulseAudio developer has a link to a scientific paper (http://www.patrickbaudisch.com/publications/2004-Baudisch-CHI04-FlatVolumeControl.pdf) that he uses for defending them, and I don't really have a good weapon against that.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Martin, do you agree to discard this one? From what I understand, there is no easy way to check if the user runs pulseaudio.</p></pre>
<br />
<p>- Christoph</p>
<br />
<p>On October 26th, 2014, 4:21 p.m. UTC, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Gardening Team and Christoph Feck.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2014, 4:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Simple approach to bug 324975, implementing a suggestion from comment #6. I was however never able to reproduce this locally, so this is "coding blind".</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If this is good-enough, I'll make a similar patch to the kcm to hide the slider in there (which was said in the bug that these should be controllable by the "event sounds" slider).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(I'm not sure to whom should I assign this so please add people as necessary)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds but I cannot reproduce the problem locally, so cannot really say if it fixes the bug.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>knotify/notifybysound.cpp <span style="color: grey">(0f5cc50)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>