<table><tr><td style="">coates added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26201">View Revision</a></tr></table><br /><div><div><p>Using <tt style="background: #ebebeb; font-size: 13px;">QRandomGenerator</tt>, but keeping <tt style="background: #ebebeb; font-size: 13px;">RAND_MAX</tt> is really only a half port. Please, use <tt style="background: #ebebeb; font-size: 13px;">QRandomGenerator</tt>'s convenient generation functions.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26201#inline-149429">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dealer.cpp:792</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// Generate a random number with an exponentional distribution averaging 1/4.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">qreal</span> <span class="n">randomExp</span> <span style="color: #aa2211">=</span> <span class="n">qMin</span><span style="color: #aa2211"><</span><span class="n">qreal</span><span style="color: #aa2211">></span><span class="p">(</span> <span style="color: #aa2211">-</span><span class="n">log</span><span class="p">(</span> <span style="color: #601200">1</span> <span style="color: #aa2211">-</span> <span class="n">qreal</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">K</span>Random<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">random</span></span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">RAND_MAX</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">4</span><span class="p">,</span> <span style="color: #601200">1</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span> <span class="n">randomExp</span> <span style="color: #aa2211">=</span> <span class="n">qMin</span><span style="color: #aa2211"><</span><span class="n">qreal</span><span style="color: #aa2211">></span><span class="p">(</span> <span style="color: #aa2211">-</span><span class="n">log</span><span class="p">(</span> <span style="color: #601200">1</span> <span style="color: #aa2211">-</span> <span class="n">qreal</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">Q</span>Random<span class="bright">Generator</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">global</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">generate</span></span><span class="p">()</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span class="n">RAND_MAX</span> <span class="p">)</span> <span style="color: #aa2211">/</span> <span style="color: #601200">4</span><span class="p">,</span> <span style="color: #601200">1</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">int</span> <span class="n">randomIndex</span> <span style="color: #aa2211">=</span> <span class="n">randomExp</span> <span style="color: #aa2211">*</span> <span class="p">(</span> <span class="n">hintList</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">1</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">qreal randomExp = qMin<qreal>( -log( 1 - QRandomGenerator::global()::generateDouble() ) / 4, 1 );</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26201#inline-149430">View Inline</a><span style="color: #4b4d51; font-weight: bold;">mainwindow.cpp:422</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">KCardTheme</span><span style="color: #aa2211">></span> <span class="n">themes</span> <span style="color: #aa2211">=</span> <span class="n">KCardTheme</span><span style="color: #aa2211">::</span><span class="n">findAll</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">KCardTheme</span> <span class="n">theme</span> <span style="color: #aa2211">=</span> <span class="n">themes</span><span class="p">.</span><span class="n">at</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">K</span>Random<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">random</span></span><span class="p">()</span> <span style="color: #aa2211">%</span> <span class="n">themes</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KCardTheme</span> <span class="n">theme</span> <span style="color: #aa2211">=</span> <span class="n">themes</span><span class="p">.</span><span class="n">at</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">Q</span>Random<span class="bright">Generator</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">global</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">generate</span></span><span class="p">()</span> <span style="color: #aa2211">%</span> <span class="n">themes</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Settings</span><span style="color: #aa2211">::</span><span class="n">setCardTheme</span><span class="p">(</span> <span class="n">theme</span><span class="p">.</span><span class="n">dirName</span><span class="p">()</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">KCardTheme theme = themes.at( QRandomGenerator::global()->bounded( themes.size() ) );</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26201#inline-149431">View Inline</a><span style="color: #4b4d51; font-weight: bold;">spider.cpp:406</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">qreal</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="n">rect</span><span class="p">.</span><span class="n">left</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">qreal</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">K</span>Random<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">random</span></span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">RAND_MAX</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span class="n">rect</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">deck</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">cardWidth</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">qreal</span> <span class="n">y</span> <span style="color: #aa2211">=</span> <span class="n">rect</span><span class="p">.</span><span class="n">top</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">qreal</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">K</span>Random<span class="bright"></span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">random</span></span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">RAND_MAX</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span class="n">rect</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">deck</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">cardHeight</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span> <span class="n">x</span> <span style="color: #aa2211">=</span> <span class="n">rect</span><span class="p">.</span><span class="n">left</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">qreal</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>Random<span class="bright">Generator</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">global</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">generate</span></span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">RAND_MAX</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span class="n">rect</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">deck</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">cardWidth</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">qreal</span> <span class="n">y</span> <span style="color: #aa2211">=</span> <span class="n">rect</span><span class="p">.</span><span class="n">top</span><span class="p">()</span> <span style="color: #aa2211">+</span> <span class="n">qreal</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">Q</span>Random<span class="bright">Generator</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">global</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">generate</span></span><span class="p">())</span> <span style="color: #aa2211">/</span> <span class="n">RAND_MAX</span> <span style="color: #aa2211">*</span> <span class="p">(</span><span class="n">rect</span><span class="p">.</span><span class="n">height</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span class="n">deck</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">cardHeight</span><span class="p">());</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">return</span> <span style="color: #004012">QPointF</span><span class="p">(</span> <span class="n">x</span><span class="p">,</span> <span class="n">y</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">qreal x = rect.left() + QRandomGenerator::global()::bounded(rect.width() - deck()->cardWidth());
qreal y = rect.top() + QRandomGenerator::global()::bounded(rect.height() - deck()->cardHeight());</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26201">https://phabricator.kde.org/D26201</a></div></div><br /><div><strong>To: </strong>nicolasfella, KDE Games, shlomif<br /><strong>Cc: </strong>coates, shlomif, kde-games-devel<br /></div>