<table><tr><td style="">twighk updated this revision to Diff 67801.<br />twighk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24570">View Revision</a></tr></table><br /><div><div><p>Instead of removing KOLFLIB, set a define when building it so it choses the correct dll linkage.</p>

<p>Make the library STATIC instead of SHARED in the cmakelists.txt . It was having different problems where it couldn't find things that were in the library when linking:</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Creating library lib\kolf.lib and object lib\kolf.exp                                                                              main.cpp.obj : error LNK2001: unresolved external symbol "public: static struct QMetaObject const KolfGame::staticMetaObject" (?staticMetaObject@KolfGame@@2UQMetaObject@@B)                                                                                                main.cpp.obj : error LNK2001: unresolved external symbol "public: static struct QMetaObject const KolfWindow::staticMetaObject" (?staticMetaObject@KolfWindow@@2UQMetaObject@@B)                                                                                            bin\kolf.exe : fatal error LNK1120: 2 unresolved externals</pre></div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D24570?vs=67746&id=67801">https://phabricator.kde.org/D24570?vs=67746&id=67801</a></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24570">https://phabricator.kde.org/D24570</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kolf-19.08.2/CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>twighk, KDE Games<br /><strong>Cc: </strong>vonreth, yurchor, kde-games-devel, krippendorf, hoetzel, hechenlan, bencreasy<br /></div>