<table><tr><td style="">wbauer added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23570">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23570#522088" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23570#522088</a>, <a href="https://phabricator.kde.org/p/fabiank/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@fabiank</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>This is hopefully already a minimal fix for the crash issues, and it does not depend on Qt 5.12 features. <a href="https://phabricator.kde.org/p/wbauer/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@wbauer</a> It would be most helpful if you could test whether the original bug is indeed no longer occurring after this patch.</p></div>
</blockquote>
<p>JFYI, I already tested the QScopeGuard fix from <a href="https://phabricator.kde.org/D23404" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D23404</a> today, it does indeed fix the crash of BUG 395624.</p>
<p>I'll give this a try too of course.</p>
<p>One note right now though:<br />
You should change "Fixes: BUG-395624" to "BUG: 395624" in the description, then the bug report will be auto-closed when you commit this... ;-)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23570">https://phabricator.kde.org/D23570</a></div></div><br /><div><strong>To: </strong>fabiank, KDE Games, shlomif, wbauer, aacid<br /><strong>Cc: </strong>wbauer, kde-games-devel<br /></div>