<table><tr><td style="">schwarzer added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23268">View Revision</a></tr></table><br /><div><div><p>Thanks indeed. Just a note for future. Try to keep patches smaller. Separate them in e.g. whitespace changes, documentation changes and code changes. <tt style="background: #ebebeb; font-size: 13px;">git add -p</tt> or <tt style="background: #ebebeb; font-size: 13px;">git commit -p</tt> helps with that.<br />
Reason: If you mix code changes with whitespace changes and then the code change turns out to be problematic, you cannot just revert the change without losing the whitespace fixes.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23268#inline-131284">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ball.cpp:111-114</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span> <span class="n">m_framesNum</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">frame</span> <span style="color: #aa2211">=</span> <span class="n">KRandom</span><span style="color: #aa2211">::</span><span class="n">random</span><span class="p">()</span> <span style="color: #aa2211">%</span> <span class="n">m_framesNum</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright"> </span><span class="p"><span class="bright">}</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is valid C++ and some style guides allow leaving out the braces ... however, during my day job I found cases, where the code was altered later and the developer added one line and forgot about adding braces. So I would always use braces on an if statement. ... But this is just my opinion.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23268#inline-131285">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gamewidget.cpp:39-48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span class="n">KBounceGameWidget</span><span style="color: #aa2211">::</span><span class="n">KBounceGameWidget</span><span class="p">(</span> <span class="n">QWidget</span><span style="color: #aa2211">*</span> <span class="n">parent</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa2211">:</span> <span class="n">QGraphicsView</span><span class="p">(</span> <span class="n">parent</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">m</span>_state</span><span class="p">(</span> <span class="n">BeforeFirstGame</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">m</span>_bonus</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">m</span>_level</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">m</span>_lives</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">m</span>_time</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">kBounceGameWidget</span>_state</span><span class="p">(</span> <span class="n">BeforeFirstGame</span> <span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// set initial game state</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">kBounceGameWidget</span>_bonus</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// set initial bonus value</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">kBounceGameWidget</span>_level</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// set initial level value</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">kBounceGameWidget</span>_lives</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// set initial lives value</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">kBounceGameWidget</span>_time</span><span class="p">(</span> <span style="color: #601200">0</span> <span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #74777d"><span class="bright">// set initial time value</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You kept the spaces inside the braces here. On purpose?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R392 KBounce</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23268">https://phabricator.kde.org/D23268</a></div></div><br /><div><strong>To: </strong>pedrohenriques, KDE Games<br /><strong>Cc: </strong>schwarzer, yurchor, kde-games-devel<br /></div>