<table><tr><td style="">aacid accepted this revision.<br />aacid added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21091">View Revision</a></tr></table><br /><div><div><p>IMNSHO the golden rule for this kind of patch is:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">is application part of KDE Applications? ☑</li>
<li class="remarkup-list-item">has application has "relatively significant" code changes since the last time the version was updated? ☑ (gui/version.h was updated in 2015, there's been fixes since then)</li>
</ul>
<p>So let's go with this.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R385 Bovo</div></div></div><br /><div><strong>BRANCH</strong><div><div>version</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21091">https://phabricator.kde.org/D21091</a></div></div><br /><div><strong>To: </strong>jriddell, ngraham, KDE Games, aacid<br /><strong>Cc: </strong>ltoscano, aacid, kde-games-devel<br /></div>