<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19920">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19920#inline-111967">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcardthemewidget.cpp:85</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright"></span><span class="n"><span class="bright">QImage</span></span><span class="bright"> </span><span class="n"><span class="bright">img</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"> </span><span class="n"><span class="bright">d</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">previewSize</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">QImage</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Format_ARGB32</span></span><span class="bright"> </span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="bright"></span><span style="color: #aa4000"><span class="bright">const</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">auto</span></span><span class="bright"> </span><span class="n"><span class="bright">dpr</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span class="n"><span class="bright">qApp</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">-></span></span><span class="bright"></span><span class="n"><span class="bright">devicePixelRatio</span></span><span class="bright"></span><span class="p"><span class="bright">(</span>);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QImage</span> <span style="color: #004012">img</span><span class="p">(</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">previewSize</span> <span style="color: #aa2211">*</span> <span class="n">dpr</span><span class="p">,</span> <span class="n">QImage</span><span style="color: #aa2211">::</span><span class="n">Format_ARGB32</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">        <span class="n">img</span><span class="p">.</span><span class="n">fill</span><span class="p">(</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">transparent</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this image doesn't have the DPR set</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19920#inline-111968">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcardthemewidget.cpp:104</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span class="n">renderer</span><span class="p">.</span><span class="n">render</span><span class="p">(</span> <span style="color: #aa2211">&</span><span class="n">p</span><span class="p">,</span> <span class="n">card</span><span class="p">,</span> <span class="n">QRectF</span><span class="p">(</span> <span class="n">QPointF</span><span class="p">(</span> <span class="n">xPos</span><span class="p">,</span> <span class="n">yPos</span> <span class="p">),</span> <span class="n">size</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">renderer</span><span class="p">.</span><span class="n">render</span><span class="p">(</span> <span style="color: #aa2211">&</span><span class="n">p</span><span class="p">,</span> <span class="n">card</span><span class="p">,</span> <span class="n">QRectF</span><span class="p">(</span> <span class="n">QPointF</span><span class="p">(</span> <span class="n">xPos</span><span class="p">,</span> <span class="n">yPos</span> <span class="p">)<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">dpr</span></span><span class="p">,</span> <span class="n">size<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">dpr</span></span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">xPos</span> <span style="color: #aa2211">+=</span> <span style="color: #601200">0.3</span> <span style="color: #aa2211">*</span> <span class="n">spacingWidth</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Any patch that has code to render bigger is normally a bad sign.</p>

<p style="padding: 0; margin: 8px;">We should only be resizing the backing stores and having the DPR set on that backing store.</p>

<p style="padding: 0; margin: 8px;">The rest will implicitly "just work".</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19920#inline-111969">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcardthemewidget.cpp:206</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QPixmap</span> <span style="color: #aa2211">*</span> <span class="n">pix</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QPixmap</span><span class="p">(</span> <span class="n">QPixmap</span><span style="color: #aa2211">::</span><span class="n">fromImage</span><span class="p">(</span> <span class="n">image</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">pix</span><span style="color: #aa2211">-></span><span class="n">setDevicePixelRatio</span><span class="p">(</span> <span class="n">qApp</span><span style="color: #aa2211">-></span><span class="n">devicePixelRatio</span><span class="p">()</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">delete</span> <span class="n">m_previews</span><span class="p">.</span><span class="n">value</span><span class="p">(</span> <span class="n">theme</span><span class="p">.</span><span class="n">displayName</span><span class="p">(),</span> <span style="color: #601200">0</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">why?</p>

<p style="padding: 0; margin: 8px;">The image coming in should have a DPR set.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19920">https://phabricator.kde.org/D19920</a></div></div><br /><div><strong>To: </strong>volkov, KDE Games<br /><strong>Cc: </strong>apol, aacid, davidedmundson, kde-games-devel<br /></div>