<table><tr><td style="">sitter created this revision.<br />Herald added a reviewer: KDE Games.<br />Herald added a subscriber: kde-games-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19590">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>parallel builds (-jNN) would fail with the new test target because it<br />
incorrectly orders itself.</p>
<p>kpat has settings.kcfg which gets generated into settings.h which gets<br />
included by (e.g. klondike.cpp), making that cpp file dependent on the<br />
generated settings.h and transitively the test target would depend on<br />
it too.<br />
since this previously was not accounted for the test target would<br />
semi-consistently fail to build when it was built before the kpat target<br />
and as a result the settings.h was not yet generated.<br />
(i.e. test before kpat => boom; test after kpat => success)</p>
<p>easy fix is forcefully setting a target dependency.</p>
<p>the much nicer solution would be to build a temporary static library which<br />
can be used by the test and the application to build the respective<br />
binaries. this would also have the neat advantage of only compiling the<br />
cpp files once (currently they get built once for the test target<br />
and then again for the kpat target). alas, currently no time to test such<br />
an invasive change. the band-aid dependency will have to do for now.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19590">https://phabricator.kde.org/D19590</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>autotests/CMakeLists.txt</div></div></div><br /><div><strong>To: </strong>sitter, KDE Games<br /><strong>Cc: </strong>kde-games-devel<br /></div>