<table><tr><td style="">cgiboudeaux added a comment.
</td></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/T8802#144359" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">T8802#144359</a>, <a href="https://phabricator.kde.org/p/shlomif/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@shlomif</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p><a href="https://phabricator.kde.org/p/cgiboudeaux/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@cgiboudeaux</a> : please see the patch in this commit - <a href="https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876</a> - i was aware of these warnings, but ignored them because the fix made performance suffer a little.</p></div>
</blockquote>

<p>Thanks, I adapted the patch for the 4.18.0 release and submitted it.</p></div></div><br /><div><strong>TASK DETAIL</strong><div><a href="https://phabricator.kde.org/T8802">https://phabricator.kde.org/T8802</a></div></div><br /><div><strong>To: </strong>cgiboudeaux<br /><strong>Cc: </strong>shlomif, cgiboudeaux, bcooksley, tcberner, adridg, fvogt, lbeltrame, KDE Games, fabiank, sysadmin, alexeymin, kaning, scarlettclark, blazquez<br /></div>