<table><tr><td style="">gregormi added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12907">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12907#inline-66459">View Inline</a><span style="color: #4b4d51; font-weight: bold;">gregormi</span> wrote in <span style="color: #4b4d51; font-weight: bold;">ksudoku.cpp:550</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">also you should move this up and have it be action(bla)->setEnabled(game.isValid())</p></blockquote>
<p style="padding: 0; margin: 8px;">oh, yes. I'll do that.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p style="padding: 0; margin: 8px;">spacing seems off here</p></blockquote>
<p style="padding: 0; margin: 8px;">This is because this file uses tabs instead of spaces. I would convert the file in a separate commit after the patch is accepted or should I do it at once?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">About spacing: my fault. Somehow the tab width in Kate was set to 8 characters instead of 4.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R417 KSudoku</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12907">https://phabricator.kde.org/D12907</a></div></div><br /><div><strong>To: </strong>gregormi, KDE Games<br /><strong>Cc: </strong>aacid, kde-games-devel<br /></div>