<table><tr><td style="">fabiank created this revision.<br />Restricted Application added a reviewer: KDE Games.<br />Restricted Application added a subscriber: KDE Games.<br />fabiank requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D11779">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>simplify if condition</p>

<p>always initialize variable</p>

<p>directly initialize variables</p>

<p>remove dead code</p>

<p>reduce variable scope, remove dead comments</p>

<p>remove declared, but unimplemented function remove unused global variable</p>

<p>removed unused member, removed member which was only ever read, never written</p>

<p>remove unnecessary forward declaration</p>

<p>remove declaration of struct that is defined below</p>

<p>remove redundant cast convert malloc + memset to calloc</p>

<p>use bool literals (clang-tidy)</p>

<p>use nullptr instead of 0 (clang-tidy)</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Manual regression testing: code still compiles, games still run, and solver can<br />
win the game</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R410 KPatience</div></div></div><br /><div><strong>BRANCH</strong><div><div>remove_dead_code</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D11779">https://phabricator.kde.org/D11779</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>clock.cpp<br />
dealer.cpp<br />
dealer.h<br />
dealerinfo.h<br />
freecell.cpp<br />
gameselectionscene.cpp<br />
gamestate.h<br />
hint.h<br />
idiot.cpp<br />
klondike.cpp<br />
klondike.h<br />
libkcardgame/kabstractcarddeck.cpp<br />
libkcardgame/kabstractcarddeck.h<br />
libkcardgame/kcard.cpp<br />
libkcardgame/kcard.h<br />
libkcardgame/kcarddeck.h<br />
libkcardgame/kcardpile.cpp<br />
libkcardgame/kcardpile.h<br />
libkcardgame/kcardscene.cpp<br />
libkcardgame/kcardscene.h<br />
libkcardgame/kcardtheme.cpp<br />
libkcardgame/kcardthemewidget.cpp<br />
libkcardgame/kcardthemewidget.h<br />
libkcardgame/kcardthemewidget_p.h<br />
main.cpp<br />
mainwindow.cpp<br />
patsolve/clocksolver.cpp<br />
patsolve/fortyeightsolver.cpp<br />
patsolve/fortyeightsolver.h<br />
patsolve/freecellsolver.cpp<br />
patsolve/golfsolver.h<br />
patsolve/grandfsolver.cpp<br />
patsolve/grandfsolver.h<br />
patsolve/gypsysolver.cpp<br />
patsolve/idiotsolver.cpp<br />
patsolve/klondikesolver.cpp<br />
patsolve/memory.cpp<br />
patsolve/memory.h<br />
patsolve/patsolve.cpp<br />
patsolve/patsolve.h<br />
patsolve/spidersolver.cpp<br />
patsolve/yukonsolver.cpp<br />
renderer.cpp<br />
renderer.h<br />
soundengine.h</div></div></div><br /><div><strong>To: </strong>fabiank, KDE Games<br /><strong>Cc: </strong>KDE Games<br /></div>