<table><tr><td style="">ltoscano added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9864" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I will fix the cmake file after this is fixed. In general, you could take a look at how this is done in other repositories).</p>
<p>The image on kde.org can be fixed by just cropping the empty borders, but I don't have access there.</p>
<p>Final notes: even if not too important, please try to reorder the tags more or less following <a href="https://techbase.kde.org/MetaInfo/Components" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/MetaInfo/Components</a> .</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9864#inline-44885" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">org.kde.klines.appdata.xml:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96"><?xml version="1.0" encoding="UTF-8"?></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"><!-- Copyright 2018 Konrad Krawiec <konrad11901@gmail.com> --></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #00702a"><component</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"desktop-application"</span><span style="color: #00702a">></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm not a lawyer, but I don't remember this header used too much in the other files.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9864#inline-44878" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">org.kde.klines.appdata.xml:18</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></description></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><categories></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><category></span>Qt<span style="color: #00702a"></category></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">According <a href="https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html" class="remarkup-link" target="_blank" rel="noreferrer">https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html</a>, "A list of valid category names can be found in the Freedesktop menu spec.", so <a href="https://specifications.freedesktop.org/menu-spec/latest/apa.html" class="remarkup-link" target="_blank" rel="noreferrer">https://specifications.freedesktop.org/menu-spec/latest/apa.html</a>. Please remove Qt and KDE, which are not categories.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9864#inline-44877" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">org.kde.klines.appdata.xml:24</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></categories></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><content_rating</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"oars-1.1"</span><span style="color: #00702a">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><content_attribute</span> <span style="color: #354bb3">id=</span><span style="color: #766510">"violence-cartoon"</span><span style="color: #00702a">></span>none<span style="color: #00702a"></content_attribute></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As the entire section is none, can you please remove it?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9864#inline-44880" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">org.kde.klines.appdata.xml:53</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"></content_rating></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><metadata_license></span>CC0-1.0<span style="color: #00702a"></metadata_license></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><project_license></span>GPL-2.0<span style="color: #00702a"></project_license></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For new files, we are trying to use FSFAP: <a href="https://spdx.org/licenses/FSFAP.html" class="remarkup-link" target="_blank" rel="noreferrer">https://spdx.org/licenses/FSFAP.html</a> <br />
Also, please put this tag on the top (see <a href="https://techbase.kde.org/MetaInfo/Components" class="remarkup-link" target="_blank" rel="noreferrer">https://techbase.kde.org/MetaInfo/Components</a> )</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9864#inline-44884" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">org.kde.klines.appdata.xml:55</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><project_license></span>GPL-2.0<span style="color: #00702a"></project_license></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><translation</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"qt"</span><span style="color: #00702a">></span>klines<span style="color: #00702a"></translation></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #00702a"><url</span> <span style="color: #354bb3">type=</span><span style="color: #766510">"bugtracker"</span><span style="color: #00702a">></span>https://bugs.kde.org/enter_bug.cgi?format=guided<span style="color: #92969d">&</span>product=klines<span style="color: #00702a"></url></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please remove this; klines is mostly gettext, but also uses many libraries from Frameworks which are either gettext or qt, and Qt is also qt. In general, we didn't define a policy for this tag so far.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R402 KLines</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9864" rel="noreferrer">https://phabricator.kde.org/D9864</a></div></div><br /><div><strong>To: </strong>kkrawiec, KDE Games, ltoscano<br /><strong>Cc: </strong>ltoscano, KDE Games<br /></div>